Skip to content

fix(data_frame): parsing empty query result value as numpy.NaN #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 21, 2023

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jun 20, 2023

Closes #550

Proposed Changes

The empty values in query results from serialization into Pandas DataFrame are returned as numpy.NaN values instead of '' - empty string.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8fa5146) 90.29% compared to head (fb19fe9) 90.30%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #584   +/-   ##
=======================================
  Coverage   90.29%   90.30%           
=======================================
  Files          39       39           
  Lines        3452     3455    +3     
=======================================
+ Hits         3117     3120    +3     
  Misses        335      335           
Impacted Files Coverage Δ
influxdb_client/client/flux_csv_parser.py 98.42% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bednar bednar changed the title fix(data_frame): parsing empty bool value as False fix(data_frame): parsing empty bool value as numpy.NaN Jun 20, 2023
@bednar bednar changed the title fix(data_frame): parsing empty bool value as numpy.NaN fix(data_frame): parsing empty query result value as numpy.NaN Jun 20, 2023
@bednar bednar force-pushed the pandas-query-bools branch from 2c3dfe9 to 50a47f0 Compare June 20, 2023 09:30
@bednar bednar marked this pull request as ready for review June 20, 2023 09:40
@bednar bednar requested review from powersj and Sciator June 20, 2023 12:22
@bednar bednar force-pushed the pandas-query-bools branch from 8bece73 to fb19fe9 Compare June 21, 2023 04:21
@bednar bednar merged commit 77cac49 into master Jun 21, 2023
@bednar bednar deleted the pandas-query-bools branch June 21, 2023 04:48
@bednar bednar added this to the 1.35.0 milestone Jun 21, 2023
@bednar bednar modified the milestones: 1.35.0, 1.37.0 Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing entrys in bool column are replaced with "None" (DataFrame)
3 participants