Skip to content

fix: duplicated debug output #521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 21, 2022
Merged

fix: duplicated debug output #521

merged 2 commits into from
Oct 21, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 21, 2022 •
edited
Loading

Closes #519

Proposed Changes

The logging.StreamHandler(sys.stdout) should appended only once into Logger.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review October 21, 2022 08:24
@bednar bednar mentioned this pull request Oct 21, 2022
Closed
@bednar bednar requested a review from powersj October 21, 2022 08:26
powersj
powersj approved these changes Oct 21, 2022
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you! Let's wait for the reporter to confirm to merge.

@powersj powersj merged commit d4f7df9 into master Oct 21, 2022
@powersj powersj deleted the fix-duplicate-logging-handler branch October 21, 2022 18:49
@bednar bednar added this to the 1.34.0 milestone Oct 22, 2022
@bednar bednar mentioned this pull request Oct 24, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.34.0
Development

Successfully merging this pull request may close these issues.

Multiplying output with every request
2 participants
@bednar @powersj