Skip to content

chore(deps): migrate to RxPY v4; set minimal Python version to 3.7 #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Aug 1, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 23, 2022

Proposed Changes

  1. Migrate to RxPY v4

    image https://rxpy.readthedocs.io/en/latest/migration.html
  2. Set minimal Python version to 3.7 (required by RxPy v4)2.
    image

    https://peps.python.org/pep-0494/

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2022

Codecov Report

Merging #472 (f4222f9) into master (f02716a) will decrease coverage by 0.12%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
- Coverage   89.50%   89.38%   -0.13%     
==========================================
  Files          38       38              
  Lines        3306     3306              
==========================================
- Hits         2959     2955       -4     
- Misses        347      351       +4     
Impacted Files Coverage Δ
influxdb_client/client/write_api.py 99.01% <100.00%> (ø)
influxdb_client/client/influxdb_client_async.py 87.93% <0.00%> (-3.45%) ⬇️
influxdb_client/client/_base.py 97.34% <0.00%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f02716a...f4222f9. Read the comment docs.

@bednar bednar changed the title chore(deps): migrate to RxPy v4; set minimal Python version to 3.7 chore(deps): migrate to RxPY v4; set minimal Python version to 3.7 Jul 23, 2022
@bednar bednar requested a review from rhajek July 23, 2022 12:57
@bednar bednar marked this pull request as ready for review July 23, 2022 12:57
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit c06cb78 into master Aug 1, 2022
@bednar bednar deleted the upgrade-rx branch August 1, 2022 05:57
@bednar bednar added this to the 1.32.0 milestone Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants