Skip to content

chore: add configuration for Dependabot #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 22, 2022
Merged

chore: add configuration for Dependabot #465

merged 3 commits into from
Jul 22, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Jul 17, 2022

Proposed Changes

Added configuration for Dependabot.

Checklist

  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2022

Codecov Report

Merging #465 (ac4d600) into master (161e202) will not change coverage.
The diff coverage is 87.50%.

@@           Coverage Diff           @@
##           master     #465   +/-   ##
=======================================
  Coverage   89.45%   89.45%           
=======================================
  Files          38       38           
  Lines        3292     3292           
=======================================
  Hits         2945     2945           
  Misses        347      347           
Impacted Files Coverage Δ
influxdb_client/configuration.py 87.64% <0.00%> (ø)
influxdb_client/__init__.py 100.00% <100.00%> (ø)
influxdb_client/_async/api_client.py 51.25% <100.00%> (ø)
influxdb_client/_sync/api_client.py 73.11% <100.00%> (ø)
influxdb_client/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 161e202...ac4d600. Read the comment docs.

@bednar bednar marked this pull request as ready for review July 17, 2022 15:26
@bednar bednar requested a review from rhajek July 17, 2022 15:26
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always happy to have dependabot. What prompted the change of CLIENT_VERISON to VERSION?

@bednar
Copy link
Contributor Author

bednar commented Jul 21, 2022

Always happy to have dependabot. What prompted the change of CLIENT_VERISON to VERSION?

Without this change the dependabot wasn't able to parse dependencies from setup.py.

https://github.com/dependabot/dependabot-core/blob/main/python/helpers/lib/parser.py

@bednar bednar merged commit c218556 into master Jul 22, 2022
@bednar bednar deleted the dependabot branch July 22, 2022 04:14
@bednar bednar added this to the 1.31.0 milestone Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants