Skip to content

chore(dependency): remove six library #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 18, 2022
Merged

chore(dependency): remove six library #439

merged 2 commits into from
May 18, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 17, 2022

Proposed Changes

Removed six library which is a Python 2 and 3 compatibility library.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are conventional
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #439 (fc66b9f) into master (e46b810) will decrease coverage by 0.02%.
The diff coverage is 80.64%.

@@            Coverage Diff             @@
##           master     #439      +/-   ##
==========================================
- Coverage   89.35%   89.32%   -0.03%     
==========================================
  Files          38       38              
  Lines        3249     3242       -7     
==========================================
- Hits         2903     2896       -7     
  Misses        346      346              
Impacted Files Coverage Δ
influxdb_client/_async/api_client.py 51.25% <66.66%> (-0.18%) ⬇️
influxdb_client/_sync/api_client.py 73.11% <77.77%> (-0.10%) ⬇️
influxdb_client/configuration.py 87.77% <83.33%> (-0.14%) ⬇️
influxdb_client/_async/rest.py 78.04% <100.00%> (-0.18%) ⬇️
influxdb_client/_sync/rest.py 85.58% <100.00%> (-0.26%) ⬇️
influxdb_client/client/write/point.py 96.71% <100.00%> (-0.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e46b810...fc66b9f. Read the comment docs.

@bednar bednar marked this pull request as ready for review May 17, 2022 08:57
@bednar bednar requested a review from rhajek May 17, 2022 08:57
Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 562f4fc into master May 18, 2022
@bednar bednar deleted the remove_six branch May 18, 2022 07:37
@bednar bednar added this to the 1.29.0 milestone May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants