Skip to content

chore: Improve error message if there is no organization with required name #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2022

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Apr 6, 2022

Closes #424

Proposed Changes

Improved error message for lookup to organization.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar marked this pull request as ready for review April 6, 2022 05:53
@bednar bednar requested a review from rhajek April 6, 2022 05:54
@bednar bednar changed the title chore: improve error message if there is no organization with required name chore: Improve error message if there is no organization with required name Apr 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Apr 6, 2022

Codecov Report

Merging #425 (e330919) into master (20c867d) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #425      +/-   ##
==========================================
+ Coverage   88.05%   88.12%   +0.07%     
==========================================
  Files          38       38              
  Lines        3197     3201       +4     
==========================================
+ Hits         2815     2821       +6     
+ Misses        382      380       -2     
Impacted Files Coverage Δ
influxdb_client/client/util/helpers.py 100.00% <100.00%> (ø)
influxdb_client/client/util/date_utils.py 96.29% <0.00%> (+7.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20c867d...e330919. Read the comment docs.

Copy link
Contributor

@rhajek rhajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bednar bednar merged commit 80f3f5f into master Apr 6, 2022
@bednar bednar deleted the org_not_found branch April 6, 2022 12:06
@bednar bednar added this to the 1.28.0 milestone Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The create_bucket method from buckets_management.py example doesn't work as documented
3 participants