Skip to content

feat(write): add support for callback notification for batching mode #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 13, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Oct 6, 2021

Proposed Changes

  1. Added support for define callbacks for hook to batches events.
  2. Added an example how to use callbacks.
  3. Added docs about error handling.

image

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #341 (5607e87) into master (76bdb62) will increase coverage by 0.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #341      +/-   ##
==========================================
+ Coverage   92.63%   92.75%   +0.11%     
==========================================
  Files          27       27              
  Lines        2254     2276      +22     
==========================================
+ Hits         2088     2111      +23     
+ Misses        166      165       -1     
Impacted Files Coverage Δ
influxdb_client/client/__init__.py 100.00% <100.00%> (ø)
influxdb_client/client/influxdb_client.py 98.13% <100.00%> (ø)
influxdb_client/client/write/__init__.py 100.00% <100.00%> (ø)
influxdb_client/client/write/retry.py 100.00% <100.00%> (ø)
influxdb_client/client/write_api.py 99.17% <100.00%> (+0.04%) ⬆️
influxdb_client/rest.py 85.18% <100.00%> (+0.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76bdb62...5607e87. Read the comment docs.

@bednar bednar requested a review from rhajek October 7, 2021 07:20
@bednar bednar marked this pull request as ready for review October 7, 2021 07:20
@bednar bednar force-pushed the feat/batching-callback-error-handling branch from fb2c3b0 to 7783025 Compare October 12, 2021 08:39
@bednar bednar force-pushed the feat/batching-callback-error-handling branch from 5607e87 to ffd9844 Compare October 12, 2021 08:58
@bednar bednar merged commit a86a561 into master Oct 13, 2021
@bednar bednar deleted the feat/batching-callback-error-handling branch October 13, 2021 05:52
@bednar bednar added this to the 1.22.0 milestone Oct 13, 2021
@bednar bednar added the enhancement New feature or request label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants