Skip to content

fix: fixing bugs in clone_task function #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 24, 2021
Merged

fix: fixing bugs in clone_task function #217

merged 7 commits into from
Mar 24, 2021

Conversation

russorat
Copy link
Contributor

Closes #216

Proposed Changes

Briefly describe your proposed changes:

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #217 (3e00ab2) into master (5e56938) will increase coverage by 0.46%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #217      +/-   ##
==========================================
+ Coverage   89.94%   90.40%   +0.46%     
==========================================
  Files          26       26              
  Lines        1969     1970       +1     
==========================================
+ Hits         1771     1781      +10     
+ Misses        198      189       -9     
Impacted Files Coverage Δ
influxdb_client/client/tasks_api.py 92.39% <100.00%> (+9.97%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e56938...3e00ab2. Read the comment docs.

@russorat russorat changed the title fix: adds dummy id to new cloned task fix: fixing bugs in clone_task function Mar 23, 2021
@bednar
Copy link
Contributor

bednar commented Mar 24, 2021

Hi @russorat, I've added a few test. I think we are ready to review by @rhajek

@bednar bednar requested a review from rhajek March 24, 2021 05:57
@rhajek rhajek merged commit 56b2624 into master Mar 24, 2021
@rhajek rhajek deleted the clone-task-fix branch March 24, 2021 09:10
@bednar bednar added this to the 1.16.0 milestone Mar 24, 2021
rhajek pushed a commit that referenced this pull request Apr 13, 2021
* fix: fixing bugs in clone_task function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone task fails due to not setting task id
3 participants