Skip to content

Remove the use of Mozilla's root certificates and certifi.where() #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 16, 2021

Conversation

borlaugen
Copy link
Contributor

@borlaugen borlaugen commented Mar 15, 2021

Closes #206

Proposed Changes

Remove the use of Mozilla's root certificates as default.

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

Copy link
Contributor

@bednar bednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR 👍

Could you please update CHANGELOG.md file and fix following code style validation:

image

@borlaugen
Copy link
Contributor Author

@bednar, I see that the test-3.6-influxdb-nightly task fails. Is this related to my pull request or something else?

Also, regarding the semantic pull request. Could you point me in the direction of how?

@bednar
Copy link
Contributor

bednar commented Mar 16, 2021

@borlaugen, thanks again for you PR.

The test-3.6-influxdb-nightly is our fault and It will be fixed after merge #209. The semantic PR requires that your commits messages and title of PR are in following format: https://www.conventionalcommits.org/en/v1.0.0/.

e.g: feat: Remove the use of Mozilla's root certificates and certific.where(), docs: updated CHANGELOG.md.

@borlaugen
Copy link
Contributor Author

@bednar, Thanks. Could we do the semantics through squasing at the end or do I have to update my commits?

@borlaugen borlaugen changed the title Remove the use of Mozilla's root certificates and certific.where() Remove the use of Mozilla's root certificates and certifi.where() Mar 16, 2021
@bednar
Copy link
Contributor

bednar commented Mar 16, 2021

Could we do the semantics through squasing at the end or do I have to update my commits?

Keep your commits as is and We will change titles in squashing.

@borlaugen
Copy link
Contributor Author

Thanks. Great product btw!

@bednar bednar merged commit e453f34 into influxdata:master Mar 16, 2021
@bednar bednar added this to the 1.16.0 milestone Mar 16, 2021
rhajek pushed a commit that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no way of using system configured ca_certs in Windows
2 participants