Skip to content

docs: fix an example about how to write Pandas.DataFrame #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 23, 2021

Conversation

bednar
Copy link
Contributor

@bednar bednar commented Feb 19, 2021

Related to a1f9826#r47111313

Proposed Changes

Fixed an example about how to write Pandas.DataFrame

Checklist

  • Rebased/mergeable
  • pytest tests completes successfully
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@bednar bednar requested a review from rhajek February 19, 2021 07:41
@bednar bednar added the documentation Improvements or additions to documentation label Feb 19, 2021
@bednar bednar marked this pull request as ready for review February 19, 2021 07:43
@codecov
Copy link

codecov bot commented Feb 19, 2021

Codecov Report

Merging #196 (deea4b4) into master (d396581) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #196   +/-   ##
=======================================
  Coverage   89.88%   89.88%           
=======================================
  Files          26       26           
  Lines        1967     1967           
=======================================
  Hits         1768     1768           
  Misses        199      199           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d396581...deea4b4. Read the comment docs.

@bednar
Copy link
Contributor Author

bednar commented Feb 22, 2021

Also "now" doesn't exist, l.332 defines _now

Fixed

@bednar bednar merged commit a3e18ee into master Feb 23, 2021
@bednar bednar deleted the docs/data-frame branch February 23, 2021 13:08
@bednar bednar added this to the 1.15.0 milestone Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants