chore: influxdb_client/client/write: fix data_frame_to_list_of_points #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogpeppe
force-pushed
the
rog-002-fix-dataframe-serializer
branch
3 times, most recently
from
735c358 to
caba68a
Compare
rogpeppe
changed the title
rogpeppe
force-pushed
the
rog-002-fix-dataframe-serializer
branch
8 times, most recently
from
d2f85a8 to
f4be9f4
Compare
Codecov Report
@@ Coverage Diff @@
## master #183 +/- ##
==========================================
+ Coverage 89.72% 89.81% +0.08%
==========================================
Files 26 26
Lines 1957 1963 +6
==========================================
+ Hits 1756 1763 +7
+ Misses 201 200 -1
Continue to review full report at Codecov.
|
philjb
reviewed
Jan 13, 2021
| print(f'measurement_name: {measurement_name}') | ||
| print(f'keys: {keys}') | ||
| print(f'tag columns: {data_frame_tag_columns}') | ||
| print(f'lambda p: f"""{{measurement_name}}{tags} {fields} {timestamp}"""') |
There was a problem hiding this comment.
Nope, that's just me debugging. This PR is still a draft as yet.
rogpeppe
force-pushed
the
rog-002-fix-dataframe-serializer
branch
2 times, most recently
from
9da33f0 to
8f03699
Compare
rogpeppe
force-pushed
the
rog-002-fix-dataframe-serializer
branch
from
8f03699 to
64df1c7
Compare
Fix the possibility of data corruption by using a much simpler regular expression to fix up the results. Also avoid mutating the DataFrame that's been passed in by making a shallow copy. This changes semantics so that if a column mentioned in `PointSettings` exists in the actual data too, it won't be overridden. Also change the `test_write_data_frame` test, which is essentially benchmarking the `data_frame_to_list_of_points` function, so that it just does that so it can easily be run on a local machine and is independent of network speed. It runs in about 10s, which is comparable to the previous performance.
rogpeppe
force-pushed
the
rog-002-fix-dataframe-serializer
branch
from
64df1c7 to
51174a1
Compare
bednar
approved these changes
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the possibility of data corruption by using a much simpler
regular expression to fix up the results.
Also avoid mutating the DataFrame that's been passed in
by making a shallow copy. This changes semantics
so that if a column mentioned in
PointSettingsexistsin the actual data too, it won't be overridden.
Also change the
test_write_data_frametest, which is essentially benchmarkingthe
data_frame_to_list_of_pointsfunction, so that it just does thatso it can easily be run on a local machine and is independent
of network speed. It runs in about 10s, which is comparable
to the previous performance.
Closes #182
pytest testscompletes successfully