-
Notifications
You must be signed in to change notification settings - Fork 185
Does the library have to require ciso8601? #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi @bullettrainio, thanks for use our client. We would like to keep the Are you able to configure your Docker builds to install client with a custom Something like: pip install influxdb-client --no-deps --requirement requirements.txt requirements.txt - without ciso8601rx >= 3.0.1
certifi >= 14.05.14
six >= 1.10
python_dateutil >= 2.5.3
setuptools >= 21.0.0
urllib3 >= 1.15.1
pytz>=2019.1 We could change the date-parsing to be tolerant to missing Is it suitable for you? Regards |
Hmm yes it would, but in this case we're using pipenv which doesnt have the ability to do Having a separate library that doesnt have the ciso dependency would be the ideal, here. But I realise that's not very clean for you guys. |
Yeah, separate library will be too painful for us 😞 |
Hi @bullettrainio, The issue is fixed in 1.9.0 milestone. If you would like to use a dev version without ciso then install client via:
Regards |
Ah thats awesome thanks |
I'm using this library in my project, but the dependency on ciso8601 is really painful. Now my docker builds need to install GCC and pythen-dev in order to satisfy
pipenv install
as part of my docker builds. This blows put the size of my docker images, and significantly increases build times.It also means its harder for people to contribute to my project as it makes their local development environment more complex.
I don't really care about date-parsing speed in my case. I would suggest having some option that doesn't depend on ciso8601.
The text was updated successfully, but these errors were encountered: