Skip to content

feat: remove trailing slash from connection URL #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2020

Conversation

bednar
Copy link
Contributor

@bednar bednar commented May 12, 2020

Releated-to influxdata/influxdb-client-python#87

  • CHANGELOG.md updated
  • Rebased/mergeable
  • Tests pass
  • Sign CLA (if not already signed)

@bednar bednar added this to the 1.8.0 milestone May 12, 2020
@bednar bednar self-assigned this May 12, 2020
@codecov-io
Copy link

Codecov Report

Merging #92 into master will increase coverage by 0.18%.
The diff coverage is 27.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   15.96%   16.15%   +0.18%     
==========================================
  Files          47       49       +2     
  Lines        4641     4792     +151     
  Branches      224      228       +4     
==========================================
+ Hits          741      774      +33     
- Misses       3880     3998     +118     
  Partials       20       20              
Impacted Files Coverage Δ
Client.Core.Test/ArgumentsDurationTest.cs 0.00% <0.00%> (ø)
Client.Core.Test/ArgumentsTest.cs 0.00% <0.00%> (ø)
Client.Core/Arguments.cs 16.00% <ø> (ø)
Client/InfluxDBClient.cs 0.00% <0.00%> (ø)
Client/Internal/ApiClient.cs 0.00% <0.00%> (ø)
Client/WriteApi.cs 0.00% <0.00%> (ø)
Client.Core/Exceptions/InfluxException.cs 89.18% <87.09%> (+1.43%) ⬆️
Client.Core/Internal/AbstractQueryClient.cs 76.81% <100.00%> (ø)
Client.Legacy/FluxClient.cs 98.37% <100.00%> (+0.06%) ⬆️
Client.Legacy/FluxConnectionOptions.cs 100.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6d2790...b50bf02. Read the comment docs.

@bednar bednar merged commit 14f0dfd into master May 12, 2020
@bednar bednar deleted the feat/trailing-last-slash branch May 12, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants