Skip to content

chore: bump unrs-resolver to v1.6.0 #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

chore: bump unrs-resolver to v1.6.0 #433

merged 1 commit into from
Apr 19, 2025

Conversation

JounQin
Copy link
Collaborator

@JounQin JounQin commented Apr 19, 2025

Important

Bump unrs-resolver to v1.6.0 and update related configurations and documentation.

  • Dependencies:
    • Bump unrs-resolver to v1.6.0 in package.json.
    • Update tinyglobby to v0.2.13 and @1stg/common-config to v13.0.1 in package.json.
  • Configuration:
    • Rename .lintstagedrc.js to .nano-staged.js and update import from @1stg/lint-staged/tsc to @1stg/nano-staged/tsc.
    • Update eslint to v9.25.0 and eslint-plugin-import-x to v4.10.5 in package.json.
  • Documentation:
    • Update README to combine "Sponsors" and "Backers" sections into "Sponsors and Backers".
    • Minor formatting changes in src/constants.ts, src/helpers.ts, and src/types.ts.

This description was created by Ellipsis for 26b8583. You can customize this summary. It will automatically update as commits are pushed.

Summary by CodeRabbit

  • Chores
    • Updated multiple dependencies to their latest versions and added new development dependencies.
    • Removed an obsolete dependency and cleaned up package resolutions.
    • Updated and reorganized the sponsorship section in the documentation for improved clarity.
    • Made minor formatting improvements to comments and documentation throughout the project.
  • Style
    • Improved formatting in comments and JSDoc annotations for better readability.

@JounQin JounQin requested a review from Copilot April 19, 2025 22:33
Copy link

changeset-bot bot commented Apr 19, 2025

🦋 Changeset detected

Latest commit: df43ad3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-import-resolver-typescript Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version of unrs-resolver to v1.6.0 while updating related documentation and configuration files. Key changes include:

  • Updating the README.md to reorganize the Sponsors and Backers sections.
  • Changing the import path in .nano-staged.js to use the new nano-staged module.
  • Adding a changeset file documenting the version bump.

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.

File Description
README.md Updated sponsors section headers for clarity.
.nano-staged.js Modified import path to the updated module.
.changeset/serious-cheetahs-wink.md Added changeset for version bump.
Files not reviewed (1)
  • package.json: Language not supported

Copy link

coderabbitai bot commented Apr 19, 2025

Walkthrough

This update primarily consists of dependency version bumps and minor documentation or formatting changes. The unrs-resolver dependency is updated to v1.6.0, and several other package versions are incremented in package.json. The README is reorganized for improved clarity in the sponsorship section. Minor formatting changes are made to comments and JSDoc annotations across several files, without affecting any logic or exported entities. No functional code changes or new features are introduced.

Changes

File(s) Change Summary
.changeset/serious-cheetahs-wink.md Adds a changeset documenting the patch update and the unrs-resolver dependency bump.
package.json Updates versions for multiple dependencies and devDependencies; adds nano-staged and @vitest/eslint-plugin, removes lint-staged, and removes a resolution override.
README.md Combines and reorganizes the "Sponsors" and "Backers" sections under a unified heading and updates badges accordingly.
.nano-staged.js Changes import source for base from @1stg/lint-staged/tsc to @1stg/nano-staged/tsc.
eslint.config.js, tests/e2e/base.eslintrc.cjs Adjusts formatting of JSDoc @import annotations for TSESLint imports.
src/constants.ts, src/helpers.ts, src/types.ts Reformats comments and JSDoc annotations for clarity and consistency; no code or logic changes.

Possibly related PRs

Suggested reviewers

  • SukkaW

Poem

🐇✨
Hopped along the version trail,
Dependencies fresh, no code to derail.
Sponsors and backers now share a space,
Comments tidied with elegant grace.
With every bump and tidy line,
This patch keeps the project fine!
— A rabbit with a changelog rhyme

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

yarn install v1.22.22
warning Resolution field "workspace:" has an invalid version entry and may be ignored
[1/4] Resolving packages...
error Couldn't find any versions for "eslint-import-resolver-typescript" that matches "workspace:
"
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e36a0ac and 26b8583.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (9)
  • .changeset/serious-cheetahs-wink.md (1 hunks)
  • .nano-staged.js (1 hunks)
  • README.md (2 hunks)
  • eslint.config.js (1 hunks)
  • package.json (2 hunks)
  • src/constants.ts (1 hunks)
  • src/helpers.ts (1 hunks)
  • src/types.ts (1 hunks)
  • tests/e2e/base.eslintrc.cjs (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (6)
  • GitHub Check: Lint and Test with Node.js 22 on windows-latest
  • GitHub Check: Lint and Test with Node.js 20 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on windows-latest
  • GitHub Check: Lint and Test with Node.js 20 on windows-latest
  • GitHub Check: Lint and Test with Node.js 22 on windows-latest
  • GitHub Check: Lint and Test with Node.js 18 on windows-latest
🔇 Additional comments (11)
.nano-staged.js (1)

1-1: Confirm import path update
The import path is correctly updated to @1stg/nano-staged/tsc, matching the renamed configuration package.

src/helpers.ts (1)

5-6: JSDoc formatting improvement
Splitting the scoped package lookup comment into two lines enhances readability without changing its meaning.

src/types.ts (1)

5-8: Consistent JSDoc style applied
Reformatted the alwaysTryTypes and bun option comments into single-line blocks for uniformity. No functional changes introduced.

src/constants.ts (1)

18-19: Clarified block comment formatting
Refactored the exclusion comment over two lines to improve clarity; content and intent remain the same.

eslint.config.js (1)

7-7: Aligned import annotation formatting
Added spaces inside { TSESLint } in the JSDoc @import tag for consistency with other configuration files.

tests/e2e/base.eslintrc.cjs (1)

4-4: Consistent JSDoc formatting in import annotation
The added spaces inside the curly braces for { TSESLint } align with the project's JSDoc style and similar changes in eslint.config.js.

.changeset/serious-cheetahs-wink.md (1)

1-6: Approve new changeset for unrs-resolver bump
The changeset correctly documents the patch-level bump of unrs-resolver to v1.6.0. This will trigger a new release with the intended dependency update.

README.md (2)

43-45: Approve updated Table of Contents entries
The TOC now includes the combined “Sponsors and Backers” section with properly indented subsections, matching the style of other nested lists.


332-335: Approve combined Sponsors and Backers section
The separate Sponsors and Backers sections have been merged under a single heading for improved clarity. Badges and tables remain intact and correctly referenced.

package.json (2)

84-86: Approve dependency version bumps
The tinyglobby and unrs-resolver packages have been safely updated to their latest patch versions. No breaking changes are expected in these libraries.


88-120: Approve devDependencies updates and additions
Dev dependencies (e.g., @1stg/common-config, eslint, @changesets/cli) have been bumped, and the new nano-staged and @vitest/eslint-plugin packages have been added to support the renamed staging configuration and testing.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codesandbox-ci bot commented Apr 19, 2025

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Apr 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.58%. Comparing base (e36a0ac) to head (26b8583).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #433   +/-   ##
=======================================
  Coverage   63.58%   63.58%           
=======================================
  Files           6        6           
  Lines         368      368           
  Branches       48       48           
=======================================
  Hits          234      234           
  Misses        134      134           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

pkg-pr-new bot commented Apr 19, 2025

Open in StackBlitz

npm i https://pkg.pr.new/eslint-import-resolver-typescript@433

commit: 26b8583

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 63ea8ea in 36 seconds. Click for details.
  • Reviewed 106 lines of code in 4 files
  • Skipped 1 files when reviewing.
  • Skipped posting 12 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/serious-cheetahs-wink.md:5
  • Draft comment:
    Changelog entry is clear.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .nano-staged.js:1
  • Draft comment:
    Ensure renaming from lint-staged to nano-staged is intentional and consistent.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
3. README.md:331
  • Draft comment:
    Sponsors/backers section reorganization improves clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. package.json:84
  • Draft comment:
    Dependency 'tinyglobby' version bump is noted; verify compatibility.
  • Reason this comment was not posted:
    Confidence changes required: 10% <= threshold 50% None
5. package.json:85
  • Draft comment:
    Bumped 'unrs-resolver' to v1.6.0 as intended.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. package.json:88
  • Draft comment:
    Update to '@1stg/common-config' should be checked for breaking changes.
  • Reason this comment was not posted:
    Confidence changes required: 20% <= threshold 50% None
7. package.json:111
  • Draft comment:
    Verify 'react' in devDependencies is intentional for this project.
  • Reason this comment was not posted:
    Confidence changes required: 30% <= threshold 50% None
8. package.json:121
  • Draft comment:
    Removal of 'es5-ext' resolution seems intentional; confirm no downstream issues.
  • Reason this comment was not posted:
    Confidence changes required: 20% <= threshold 50% None
9. .changeset/serious-cheetahs-wink.md:5
  • Draft comment:
    Changeset file looks good; bump message is clear.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
10. .nano-staged.js:1
  • Draft comment:
    Updated to use '@1stg/nano-staged/tsc'; this tooling rename is applied correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
11. README.md:331
  • Draft comment:
    Sponsors & Backers section has been restructured for clarity; formatting improvements look good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
12. package.json:84
  • Draft comment:
    Dependency version bumps and the switch from 'lint-staged' to 'nano-staged' are consistent; ensure all tooling is updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None

Workflow ID: wflow_ZxDIlzm3lYzo2bBD

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

github-actions bot commented Apr 19, 2025

size-limit report 📦

Path Size
lib/index.js 1.41 KB (0%)

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 26b8583 in 46 seconds. Click for details.
  • Reviewed 192 lines of code in 9 files
  • Skipped 0 files when reviewing.
  • Skipped posting 15 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. .changeset/serious-cheetahs-wink.md:2
  • Draft comment:
    Changeset looks correct for a version bump; ensure consistency with package.json.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. .nano-staged.js:1
  • Draft comment:
    Import path updated to '@1stg/nano-staged/tsc'; verify package renaming is intentional.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
3. README.md:42
  • Draft comment:
    Sponsors and Backers section has been reorganized; double-check all links and image URLs.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
4. package.json:84
  • Draft comment:
    Dependency versions (e.g. unrs-resolver and tinyglobby) have been bumped; confirm these updates are compatible.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
5. src/types.ts:5
  • Draft comment:
    Formatting improvements in inline comments; looks clearer now.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
6. .changeset/serious-cheetahs-wink.md:5
  • Draft comment:
    Changeset entry is clear; bump of unrs-resolver to v1.6.0 is correctly noted.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
7. .nano-staged.js:1
  • Draft comment:
    Renamed config to nano-staged and updated import; ensure CI and documentation reference the new name.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
8. README.md:332
  • Draft comment:
    Sponsors and Backers section has been restructured for clarity. Verify that the combined heading with nested subheadings aligns with project branding.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
9. eslint.config.js:7
  • Draft comment:
    JSDoc formatting update (@import spacing) improves clarity; no functional changes.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
10. package.json:81
  • Draft comment:
    Dependency versions have been bumped (e.g., unrs-resolver to v1.6.0, tinyglobby to v0.2.13). Ensure these updates are compatible and that any breaking changes are addressed.
  • Reason this comment was not posted:
    Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is about dependency version changes and asks the author to ensure compatibility and address breaking changes. According to the rules, comments on dependency changes or asking the author to ensure compatibility are not allowed.
11. src/constants.ts:17
  • Draft comment:
    Reformatted doc comment for defaultExtensions improves readability without affecting logic.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
12. src/helpers.ts:4
  • Draft comment:
    Doc comment in mangleScopedPackage now spans multiple lines for better clarity.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
13. src/types.ts:5
  • Draft comment:
    Concise JSDoc formatting in the TypeScriptResolverOptions interface improves clarity; looks good.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
14. tests/e2e/base.eslintrc.cjs:4
  • Draft comment:
    Reformatted JSDoc @import comment in the ESLint config improves readability without changing functionality.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
15. README.md:51
  • Draft comment:
    Typographical issue: In the sentence 'After version 2.0.0, .d.ts will take higher priority then normal .js/.jsx files...', 'then' should be replaced with 'than' to correctly indicate comparison.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_WRvJYfczZsNRng0U

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@JounQin JounQin merged commit 834b11e into master Apr 19, 2025
31 checks passed
@JounQin JounQin deleted the chore/bump branch April 19, 2025 22:46
@alimd
Copy link

alimd commented Apr 20, 2025

I’m encountering an issue related to this pull request!

I encountered a build error when using [email protected] in a project that utilizes Yarn Plug'n'Play (PnP).

The error message indicates that napi-postinstall attempts to access tslib, but it is not declared as a direct dependency in the napi-postinstall package. This violates Yarn PnP's strict dependency resolution and prevents the build from succeeding.

More info: #436 and unrs/unrs-resolver#71

@alimd
Copy link

alimd commented Apr 20, 2025

@JounQin

renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 20, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 4.3.1 | 4.3.3 |


## [v4.3.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#433)

##### Patch Changes

-   [#433](import-js/eslint-import-resolver-typescript#433) [`834b11e`](import-js/eslint-import-resolver-typescript@834b11e) Thanks [@JounQin](https://github.com/JounQin)! - chore: bump `unrs-resolver` to v1.6.0


## [v4.3.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#432)

##### Patch Changes

-   [#427](import-js/eslint-import-resolver-typescript#427) [`dabba8e`](import-js/eslint-import-resolver-typescript@dabba8e) Thanks [@JounQin](https://github.com/JounQin)! - chore: bump `unrs-resolver` to v1.4.1
renovate bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Apr 23, 2025
| datasource | package                           | from  | to    |
| ---------- | --------------------------------- | ----- | ----- |
| npm        | eslint-import-resolver-typescript | 4.3.1 | 4.3.4 |


## [v4.3.4](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#434)

##### Patch Changes

-   [#442](import-js/eslint-import-resolver-typescript#442) [`57611d9`](import-js/eslint-import-resolver-typescript@57611d9) Thanks [@JounQin](https://github.com/JounQin)! - fix: add more extension aliases for ts source/declaration files

-   [#444](import-js/eslint-import-resolver-typescript#444) [`bd45fcd`](import-js/eslint-import-resolver-typescript@bd45fcd) Thanks [@JounQin](https://github.com/JounQin)! - fix(deps): bump `unrs-resolver` which resolves [#406](import-js/eslint-import-resolver-typescript#406), [#409](import-js/eslint-import-resolver-typescript#409), [#437](import-js/eslint-import-resolver-typescript#437)


## [v4.3.3](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#433)

##### Patch Changes

-   [#433](import-js/eslint-import-resolver-typescript#433) [`834b11e`](import-js/eslint-import-resolver-typescript@834b11e) Thanks [@JounQin](https://github.com/JounQin)! - chore: bump `unrs-resolver` to v1.6.0


## [v4.3.2](https://github.com/import-js/eslint-import-resolver-typescript/blob/HEAD/CHANGELOG.md#432)

##### Patch Changes

-   [#427](import-js/eslint-import-resolver-typescript#427) [`dabba8e`](import-js/eslint-import-resolver-typescript@dabba8e) Thanks [@JounQin](https://github.com/JounQin)! - chore: bump `unrs-resolver` to v1.4.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants