Skip to content

fix: don't set empty configFile when no tsconfig found #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 18, 2025
+94 −55
Merged

fix: don't set empty configFile when no tsconfig found #394

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6a368d6
chore: bump `rspack-resolver` to v1.2.0
JounQin Mar 18, 2025
29a27ac
fix: don't set empty `configFile` when no tsconfig found
JounQin Mar 18, 2025
72ccbad
ci: run `pkg-pr-new publish` for any commits
JounQin Mar 18, 2025
4ce4b98
Create modern-turtles-hide.md
JounQin Mar 18, 2025
11bd719
Create good-queens-shout.md
JounQin Mar 18, 2025
ea0b1ae
ci: split pkg-pr-new action
JounQin Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/good-queens-shout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-import-resolver-typescript": patch
---

fix: don't set empty `configFile` when no `tsconfig` found
5 changes: 5 additions & 0 deletions .changeset/modern-turtles-hide.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"eslint-import-resolver-typescript": patch
---

chore: bump `rspack-resolver` to v1.2.0
30 changes: 30 additions & 0 deletions .github/workflows/pkg-pr-new.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: Publish Any Commit
on:
- push
- pull_request

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
publish:
runs-on: ubuntu-latest

steps:
- name: Checkout Repo
uses: actions/checkout@v4

- name: Setup Node.js LTS
uses: actions/setup-node@v4
with:
node-version: lts/*
cache: yarn

- name: Install dependencies
run: yarn --immutable

- name: Build
run: yarn build

- run: yarn dlx pkg-pr-new publish
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@
"dependencies": {
"debug": "^4.4.0",
"get-tsconfig": "^4.10.0",
"rspack-resolver": "^1.1.2",
"rspack-resolver": "^1.2.0",
"stable-hash": "^0.0.5",
"tinyglobby": "^0.2.12"
},
Expand Down
7 changes: 3 additions & 4 deletions src/normalize-options.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,9 @@ export function normalizeOptions(
mainFields: defaultMainFields,
...options,
project,
tsconfig: {
references: references ?? 'auto',
configFile: configFile || '',
},
tsconfig: configFile
? { references: references ?? 'auto', configFile: configFile }
: undefined,
}

if (configFile) {
Expand Down
100 changes: 50 additions & 50 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4248,81 +4248,81 @@ __metadata:
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-darwin-arm64@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-darwin-arm64@npm:1.1.2"
"@unrs/rspack-resolver-binding-darwin-arm64@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-darwin-arm64@npm:1.2.0"
conditions: os=darwin & cpu=arm64
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-darwin-x64@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-darwin-x64@npm:1.1.2"
"@unrs/rspack-resolver-binding-darwin-x64@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-darwin-x64@npm:1.2.0"
conditions: os=darwin & cpu=x64
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-freebsd-x64@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-freebsd-x64@npm:1.1.2"
"@unrs/rspack-resolver-binding-freebsd-x64@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-freebsd-x64@npm:1.2.0"
conditions: os=freebsd & cpu=x64
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-linux-arm-gnueabihf@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-linux-arm-gnueabihf@npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm-gnueabihf@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-linux-arm-gnueabihf@npm:1.2.0"
conditions: os=linux & cpu=arm
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-linux-arm64-gnu@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-linux-arm64-gnu@npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm64-gnu@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-linux-arm64-gnu@npm:1.2.0"
conditions: os=linux & cpu=arm64 & libc=glibc
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-linux-arm64-musl@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-linux-arm64-musl@npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm64-musl@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-linux-arm64-musl@npm:1.2.0"
conditions: os=linux & cpu=arm64 & libc=musl
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-linux-x64-gnu@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-linux-x64-gnu@npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-x64-gnu@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-linux-x64-gnu@npm:1.2.0"
conditions: os=linux & cpu=x64 & libc=glibc
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-linux-x64-musl@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-linux-x64-musl@npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-x64-musl@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-linux-x64-musl@npm:1.2.0"
conditions: os=linux & cpu=x64 & libc=musl
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-wasm32-wasi@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-wasm32-wasi@npm:1.1.2"
"@unrs/rspack-resolver-binding-wasm32-wasi@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-wasm32-wasi@npm:1.2.0"
dependencies:
"@napi-rs/wasm-runtime": "npm:^0.2.7"
conditions: cpu=wasm32
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-win32-arm64-msvc@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-win32-arm64-msvc@npm:1.1.2"
"@unrs/rspack-resolver-binding-win32-arm64-msvc@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-win32-arm64-msvc@npm:1.2.0"
conditions: os=win32 & cpu=arm64
languageName: node
linkType: hard

"@unrs/rspack-resolver-binding-win32-x64-msvc@npm:1.1.2":
version: 1.1.2
resolution: "@unrs/rspack-resolver-binding-win32-x64-msvc@npm:1.1.2"
"@unrs/rspack-resolver-binding-win32-x64-msvc@npm:1.2.0":
version: 1.2.0
resolution: "@unrs/rspack-resolver-binding-win32-x64-msvc@npm:1.2.0"
conditions: os=win32 & cpu=x64
languageName: node
linkType: hard
Expand Down Expand Up @@ -6702,7 +6702,7 @@ __metadata:
npm-run-all2: "npm:^7.0.2"
prettier: "npm:^3.5.3"
react: "npm:^19.0.0"
rspack-resolver: "npm:^1.1.2"
rspack-resolver: "npm:^1.2.0"
simple-git-hooks: "npm:^2.11.1"
size-limit: "npm:^11.2.0"
size-limit-preset-node-lib: "npm:^0.3.0"
Expand Down Expand Up @@ -13210,21 +13210,21 @@ __metadata:
languageName: node
linkType: hard

"rspack-resolver@npm:^1.1.0, rspack-resolver@npm:^1.1.2":
version: 1.1.2
resolution: "rspack-resolver@npm:1.1.2"
dependencies:
"@unrs/rspack-resolver-binding-darwin-arm64": "npm:1.1.2"
"@unrs/rspack-resolver-binding-darwin-x64": "npm:1.1.2"
"@unrs/rspack-resolver-binding-freebsd-x64": "npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm-gnueabihf": "npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm64-gnu": "npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-arm64-musl": "npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-x64-gnu": "npm:1.1.2"
"@unrs/rspack-resolver-binding-linux-x64-musl": "npm:1.1.2"
"@unrs/rspack-resolver-binding-wasm32-wasi": "npm:1.1.2"
"@unrs/rspack-resolver-binding-win32-arm64-msvc": "npm:1.1.2"
"@unrs/rspack-resolver-binding-win32-x64-msvc": "npm:1.1.2"
"rspack-resolver@npm:^1.1.0, rspack-resolver@npm:^1.2.0":
version: 1.2.0
resolution: "rspack-resolver@npm:1.2.0"
dependencies:
"@unrs/rspack-resolver-binding-darwin-arm64": "npm:1.2.0"
"@unrs/rspack-resolver-binding-darwin-x64": "npm:1.2.0"
"@unrs/rspack-resolver-binding-freebsd-x64": "npm:1.2.0"
"@unrs/rspack-resolver-binding-linux-arm-gnueabihf": "npm:1.2.0"
"@unrs/rspack-resolver-binding-linux-arm64-gnu": "npm:1.2.0"
"@unrs/rspack-resolver-binding-linux-arm64-musl": "npm:1.2.0"
"@unrs/rspack-resolver-binding-linux-x64-gnu": "npm:1.2.0"
"@unrs/rspack-resolver-binding-linux-x64-musl": "npm:1.2.0"
"@unrs/rspack-resolver-binding-wasm32-wasi": "npm:1.2.0"
"@unrs/rspack-resolver-binding-win32-arm64-msvc": "npm:1.2.0"
"@unrs/rspack-resolver-binding-win32-x64-msvc": "npm:1.2.0"
dependenciesMeta:
"@unrs/rspack-resolver-binding-darwin-arm64":
optional: true
Expand All @@ -13248,7 +13248,7 @@ __metadata:
optional: true
"@unrs/rspack-resolver-binding-win32-x64-msvc":
optional: true
checksum: 10/116fadb51a778560a079d82874e85d519a82f54987992fbde766c912597c347f5517cd7f8223bcc2658e742b8cd4f3beb5d994a48b0fbbe4818af75dcf994481
checksum: 10/c2b869ba530bfa419142130118b543de63f62a1999df7680fffad1ff66b92fc2be7f8d8dfc146ee4a31bcae7f6ab5bd6fd1ec99fd64c0287bbdd9b030ff7ffd8
languageName: node
linkType: hard

Expand Down