Skip to content

Add Service to Worker Pattern #2004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 18, 2022
Merged

Add Service to Worker Pattern #2004

merged 4 commits into from
Sep 18, 2022

Conversation

Liu-rj
Copy link
Contributor

@Liu-rj Liu-rj commented May 21, 2022

Pull request title

Pull request description

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

96.2% 96.2% Coverage
0.0% 0.0% Duplication

iluwatar
iluwatar approved these changes Sep 18, 2022
View reviewed changes
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Perhaps I would have copied the dependent classes from model-view-controller into this example, but it's not a big deal. Thank you for your contribution!

@iluwatar iluwatar self-assigned this Sep 18, 2022
@iluwatar iluwatar added this to the 1.26.0 milestone Sep 18, 2022
@iluwatar iluwatar merged commit 953af7c into iluwatar:master Sep 18, 2022
@iluwatar
Copy link
Owner

@all-contributors please add @Liu-rj for code

@allcontributors allcontributors bot mentioned this pull request Sep 18, 2022
Merged
@allcontributors
Copy link
Contributor

@iluwatar

I've put up a pull request to add @Liu-rj! 🎉

@Liu-rj Liu-rj deleted the new1262 branch September 18, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluwatar iluwatar iluwatar approved these changes

Assignees

@iluwatar iluwatar

Labels
status: under review
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Liu-rj @iluwatar