Skip to content

Package patterns into executable jars setup #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Nov 19, 2019

Conversation

hbothra15
Copy link
Contributor

Package patterns into executable jars

  • In this PR i have tried to create the base structure in parent pom and try to implement for abstarct document, if everything looks good then can replicate the same to other packages as well.
  • This PR will resolve the issue#989 partially and if approved will do the required changes for other as well

Pull request description

  • This PR will have change in parent pom where we have steup the plugin managment for maven assembley plugin and leveraging the same for abstract-document pattern

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed structure looks good. There are some conflicts that prevent merging of this branch.

hbothra15 and others added 3 commits November 18, 2019 10:27
Resync to remove conflicts
# Conflicts:
#	abstract-document/pom.xml
#	pom.xml
@hbothra15
Copy link
Contributor Author

Fixed the conflict

@hbothra15
Copy link
Contributor Author

Hi @iluwatar ,
I would like to know, how to handle patterns which are having sub modules withing them like api-gateway, aggregator-microservices

As of now I have set plugin in each sub module to generate respective jar

@iluwatar
Copy link
Owner

@hbothra15 that is the correct approach. In the microservices example we have 3 submodules that should each be runnable using java -jar .... Aggregator service requires that information and inventory microservices are running so that it can fetch some information from them.

@hbothra15
Copy link
Contributor Author

If there is no conflict can we proceed with first MR, and I will be raising others in batches

@iluwatar iluwatar added this to the 1.23.0 milestone Nov 19, 2019
@iluwatar iluwatar merged commit e0b728c into iluwatar:master Nov 19, 2019
@iluwatar
Copy link
Owner

Thanks @hbothra15 for the first set.

@iluwatar
Copy link
Owner

#989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants