Skip to content

Improve logo visibility on Dark Theme #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

khantiRindani
Copy link
Contributor

@khantiRindani khantiRindani commented Jul 31, 2024

Coming across this repository was a great find for me! Thank you so much for putting in lots of efforts and creating this extensive java knowledge-base.

Change Description:

I just wanted to propose a minor styling enhancement for dark themed users. It seems that coffee icon logo is not properly visible in dark theme.

Results:

Tested in local

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for relaxed-kleicha-7210ed ready!

Name Link
🔨 Latest commit 9d27dc2
🔍 Latest deploy log https://app.netlify.com/sites/relaxed-kleicha-7210ed/deploys/66a9c93ff29c350008be0217
😎 Deploy Preview https://deploy-preview-96--relaxed-kleicha-7210ed.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iluwatar iluwatar merged commit d3cfe0b into iluwatar:main Aug 1, 2024
4 checks passed
@iluwatar
Copy link
Owner

iluwatar commented Aug 1, 2024

Looks good! Thank you so much for fixing this @khantiRindani 💪 🙂

@khantiRindani
Copy link
Contributor Author

Thank you so much for the consideration @iluwatar. I'm looking forward to contribute more and join in your noble mission.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants