Skip to content

Create pull_request_template.md #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2022
Merged

Create pull_request_template.md #84

merged 2 commits into from
Oct 30, 2022

Conversation

ignacio-chiazzo
Copy link
Owner

Added a pull request template.

cc @hot9cups Thoughts?

hot9cups
hot9cups approved these changes Oct 30, 2022
View reviewed changes
Copy link
Collaborator

@hot9cups hot9cups left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, maybe a minor suggestion would be to also add the point - I have run the unit tests and linting test locally - and we could link to the specific section in the readme that shows how to do that :)

@ignacio-chiazzo
Copy link
Owner Author

Good good point. Added.

@ignacio-chiazzo ignacio-chiazzo merged commit 030cf4a into master Oct 30, 2022
@ignacio-chiazzo ignacio-chiazzo deleted the ignacio-chiazzo-patch-1 branch April 4, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hot9cups hot9cups hot9cups approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ignacio-chiazzo @hot9cups