chore: angular upgrade from 11 to 12 #297
Conversation
Unit Test Results 2 files 15 suites 19s ⏱️ Results for commit 2c98012. |
Codecov Report
@@ Coverage Diff @@
## main #297 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 49 49
Lines 655 655
Branches 62 62
=========================================
Hits 655 655 Continue to review full report at Codecov.
|
|
Don't forget to update peer dependencies in hyperdash angular lib. |
| @@ -8,7 +8,7 @@ | |||
| "test": "ng test", | |||
| "lint": "ng lint", | |||
| "commit": "git-cz", | |||
| "build:ci": "ng build --prod hyperdash-angular && ng build --prod hyperdash-angular-app", | |||
| "build:ci": "ng build --configuration production hyperdash-angular && ng build --configuration production hyperdash-angular-app", | |||
There was a problem hiding this comment.
do we need to add a configuration flag here? I think Angular is moving towards prod build by default anyway. I would say let's opt in for this feature.
@aaron-steinfeld thoughts?
You can run the optional migration for enabling production builds by default ng update @angular/cli@12 --migrate-only production-by-default.
There was a problem hiding this comment.
We should also enable NG_PERSISTENT_BUILD_CACHE for faster build.
"start": "NG_PERSISTENT_BUILD_CACHE=1 ng serve",
"build": "NG_PERSISTENT_BUILD_CACHE=1 ng build",
There was a problem hiding this comment.
I would say let's opt in for this feature.
So we can certainly compare build times, but does this mean our local builds would be minified, not source mapped etc? If so, I'd be against it. In other words, what is the advantage of doing a prod build locally other than a greater fidelity to the final state?
There was a problem hiding this comment.
They have better template checking. I would also not want to miss out on source map.
| "@angular/forms": "^12.2.1", | ||
| "@angular/platform-browser": "^12.2.1", | ||
| "@angular/platform-browser-dynamic": "^12.2.1", | ||
| "@angular/router": "^12.2.1", |
There was a problem hiding this comment.
This should bump zone.js too right?
There was a problem hiding this comment.
This is on latest version https://www.npmjs.com/package/zone.js?activeTab=versions
|
@aaron-steinfeld Please take a look |
|
Some issue |
Description
Angular upgrade from 11 to 12