Output the package name #162
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hynek
reviewed
Feb 15, 2025
| @@ -251,8 +254,10 @@ runs: | |||
| if match := re.match(r"Programming Language :: Python :: (\d+\.\d+)$", classifier): | |||
| version_tokens.append(match.group(1)) | |||
|
|
|||
| package_name = pkg_info.get("Name") | |||
There was a problem hiding this comment.
I don't think this can realistically happen (build backends should catch this), but if it does, I think we should fail with a helpful error message here?
There was a problem hiding this comment.
You mean if Name is missing? The spec does say it's required, but we could probably emit an error.
There was a problem hiding this comment.
Yeah that's what I mean. Emitting an error sounds great although I doubt the other tooling will allow us to get as far. :) Always good to add more assertions.
|
ping? 😇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Hynek!
Do let me know if this going a bit far in scope for this action, but the use case is essentially what I put in the updated example 😄
Similar to #152.