Omit Normalization Layer from MLP Class #1852
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #1851. The unused normalization layer is omitted from the Mlp class. Usage of the
norm_layer
argument is also omitted. Both BEiT(-v2) and EVA(-02) models are not affected by this change. EVA(-02) uses thenorm_layer
argument but since all configurations are using the SwiGLU instead if Mlp existing model weights are not affected. BEiT(-v2) sets in all configurationsscale_mlp=False
, meaningnorm_layer
was set toNone
, thus, also no affect here on existing models/weights.