Update to SpeechBrain v1.0 #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This PR is because SB is now stable and the v1 is released.
I'd like to mention that I ran the tests, and some of them fail, but I simply can't understand why as I was not able to get the exception. I tested the code corresponding to the test locally, on the same environment than the test, and it works.
I ran
pytest -v --tb=native -sv --rootdir docker_images/speechbrain/ docker_images/speechbrain/. Weirdly, all the interfaces work when I try them locally :-(I also tried to just remove entirely the content of the call, just returning a dummy expected variable of the right type, and the tests would still fail, which sounds surprising to me.
Many thanks!