Added client's req object to proxyRes event
#635
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The req object gives listeners of the proxyRes event access to the original client request, and thus allows accessing the session and identifying the user for whom we are doing the routing operation. Added the req object as second parameter, so it won't break existing code.
|
I'd also find it very useful to have access to the req object in this situation :-) |
|
Actually, further to this, it would be great to have access to the res object as well. |
|
@bruce-one id take an updated PR on this :) |
|
I created a new pull request - #642 - as I wasn't sure about updating other people's pull requests :-s |
|
fixed in #642 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The req object gives listeners of the proxyRes event access to the original client request, and thus allows accessing the session and identifying the user for whom we are doing the routing operation. Added the req object as second parameter, so it won't break existing code.