Include websocket non-upgrade response #1184
Conversation
|
To expand a bit: This will allow node-http-proxy to support some authentication schemes when required by the remote server. If this is supported depends on the browser, but Chrome and Firefox for example will happily work with digest authentication with this addition. Even if we disregard the added benefits above it seems correct for the proxy to relay back the error messages from the server, whatever it may be. |
Tigge
force-pushed
the
websocket-upgrade-fail-response
branch
from
80331bd to
a04e0f7
Compare
When the server do not accept the upgrade request for websockets the server's response was previously not included and sent back. Now the proxy will include the response in these cases. Fixes http-party#890. Change-Id: I142a15ee12603f54d611ae9362a94c62fb3c9f36
Tigge
force-pushed
the
websocket-upgrade-fail-response
branch
from
a04e0f7 to
9600092
Compare
|
@jcrugzz I think the remaining test issues are caused by socket.io using const and not by any changes I have introduced. The test would probably fail on master now as well. Any thoughts on how to proceed? |
|
@Tigge thanks! I am cherry-picking this into my maintenance branch so that I can get this merged in later tonight in one go as I go through all the PRs. |
|
superseded by #1251 |
When the server do not accept the upgrade request for websockets the
response was previously not included and sent back. Now the proxy will
include the headers and the content from the server and the response in
these cases. Fixes #890.