bug or feature? proxying express+socket.io not working out-of-the-box

Hi,

I've got an express & socket.io server running, and got node-http-proxy in front of it.
When I do this:

var server = httpProxy.createServer(function (req, res, proxy) {
proxy.proxyRequest(req, res, {
host: '127.0.0.1',
port: '3000'
})
}).listen(8080, '[snip]');

Then it does not seem to proxy websockets. Now the README has something to say about that, but I'm confused - should or shouldn't this work out-of-the-box in my case?

When using the example going with the README, it works fine.. However, that example sets up a specific HttpProxy object in combination with a regular http.createServer(). But I really want to stick to the httpProxy.createServer(), and I do not see how to do that.

Any thoughts?

[indutny]

There're two ways to proxy websocket requests with .createServer(...) API:

1. https://github.com/nodejitsu/node-http-proxy/blob/master/lib/node-http-proxy.js#L184 <- do not use request handler (callback), provied target server's address as argument of .createServer
2. Listen for upgrade event on server object in your example and do server.proxy.proxyWebSocketRequest(req, socket, head);

Alright, got it to work after your suggestions, thanks. But maybe there's room for improvement, in case I'd love to hear more.

There are several websites running on multiple ports on the same server, the proxy should route these including support for websockets, but there are also other things happening such as redirection. So there's a server instantiated via httpProxy.createServer(), which based on req.headers.host will take appropriate action.

Then there's an extra listener for the upgrade event. There again is checking of the req.headers.host, and then the proxyWebSocketRequest is called with additional options specifying the target.

[bkw]

sorry, typo in the issue number, I meant 266.