Skip to content

Set-Cookie headers do not get combined in 1.16 #1101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
tomlagier opened this issue Dec 3, 2016 · 2 comments
Closed

Set-Cookie headers do not get combined in 1.16 #1101

tomlagier opened this issue Dec 3, 2016 · 2 comments

Comments

@tomlagier
Copy link

tomlagier commented Dec 3, 2016 •
edited
Loading

Minor version bump of http-proxy caused our Ember-cli app to only forward a single cookie from the back-end, rather than all cookies. I believe this is because of the rewrite to web-outgoing.js/writeHeaders.

 Set-Cookie: GOP_LOGIN=1001; Path=/; Domain=localhost
 Set-Cookie: GOP_ACCOUNT=1001; Path=/; Domain=localhost
 Set-Cookie: PLAY_SESSION="xxx"; Path=/

Gets turned into this in the response header:

Set-Cookie:GOP_ACCOUNT=1001; Path=/; Domain=localhost
@kriswill kriswill mentioned this issue Dec 3, 2016
Closed
kriswill pushed a commit to kriswill/node-http-proxy that referenced this issue Dec 4, 2016
Enable proxy response to have multiple Set-Cookie raw headers http-pa…
e4a7498 
…rty#1101
jcrugzz pushed a commit that referenced this issue Dec 4, 2016
@jcrugzz
Enable proxy response to have multiple Set-Cookie raw headers #1101
8cb451f
@kriswill
Copy link
Contributor

kriswill commented Dec 4, 2016

@jcrugzz @tomlagier this should be fixed now, please retest!

@jcrugzz
Copy link
Contributor

jcrugzz commented Dec 4, 2016

Yes this should be fixed with the changes made by @kriswill. Will reopen if this is still a problem. My apologies for the trouble.

@jcrugzz jcrugzz closed this as completed Dec 4, 2016
@pachirel pachirel mentioned this issue Dec 6, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kriswill @jcrugzz @tomlagier