Add a bunch more tests for annotation-xml #80
Conversation
|
|
||
| #data | ||
| <math><annotation-xml> </annotation-xml> | ||
| #errors |
There was a problem hiding this comment.
Should expect some errors for these new tests, right?
There was a problem hiding this comment.
Yeah, we should. But AFAIK the errors in general are frequently wrong and I felt like giving up when I did this.
There was a problem hiding this comment.
I found the errors that existed were very helpful when writing a parser, but I understand it's a pain to add and maintain them.
There was a problem hiding this comment.
@nolanw I just don't have anything off-hand that's up-to-date to generate them from, which is what makes it a real pain. (HTMLReader doesn't have any easy-to-run test binary, does it? That, say, takes input from either a file or stdin and dumps the test expectation format?)
There was a problem hiding this comment.
I kinda gave up on the errors once things mostly worked ok (surprise!). That's a good idea for a lil binary though, I'll tuck that under my hat and maybe one day the errors will rain down on us all.
|
OK, LGTM with the "x" change |
No description provided.