-
Notifications
You must be signed in to change notification settings - Fork 63
Fix tokenizer EOF error positions #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds fine. I'll give it a few days for others to comment; ping me if I forget
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe absence of errors is correct because ¬
(without a semicolon) is a valid character reference. This is also in line with what Firefox does to the HTML document a¬i
, which decodes as a¬i
.
In fact if you check the spec,
|
Thanks a lot for flagging @untitaker. I've reverted the additions. |
error locations are not actually standardized, right? this is just to make the testsuite internally consistent? |
That is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not a maintainer but this lgtm
I am trying to move parse5 to the upstream html5lib-tests repo (away from this fork). As a first PR to come from this effort, this PR corrects some tokenizer errors. The changes are in three categories:
Reverted.unknown-named-character-reference
errors were missing entirely and have been added.