Skip to content

Test parsing of the <search> element #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 11, 2022
Merged

Test parsing of the <search> element #142

merged 2 commits into from
Feb 11, 2022

Conversation

zcorpan
Copy link
Contributor

@zcorpan zcorpan commented Feb 10, 2022

@zcorpan zcorpan mentioned this pull request Feb 10, 2022
Merged
7 tasks
domenic
domenic approved these changes Feb 11, 2022
View reviewed changes
Copy link

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert in this test format, but generally LGTM. Should there be a test case involving button elements since apparently those are special??

@zcorpan
Copy link
Contributor Author

zcorpan commented Feb 11, 2022

button is special in relation to p (in that </button> generates implied end tags), but not in relation to search. So no need to add new tests for button here I think.

However I don't see a test for <button><p></button>x, so that is missing coverage. I can file an issue.

@zcorpan zcorpan mentioned this pull request Feb 11, 2022
Closed
@zcorpan
Copy link
Contributor Author

zcorpan commented Feb 11, 2022

Actually, button is relevant here. I glossed over the "button scope" thing, until I saw your comment here!

The relevant test would be:

<!doctype html><p><button><search>

(which should not close the p)

@zcorpan zcorpan force-pushed the bocoup/search-element branch from bea6065 to 5b6f2d5 Compare February 11, 2022 01:22
@zcorpan
Copy link
Contributor Author

zcorpan commented Feb 11, 2022

Fixed. I also tested the other start tags, for completeness.

@sideshowbarker sideshowbarker merged commit 8fbcde0 into master Feb 11, 2022
@sideshowbarker sideshowbarker deleted the bocoup/search-element branch February 11, 2022 08:45
@flavorjones flavorjones mentioned this pull request Jun 5, 2022
Merged
@ju1ius ju1ius mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker approved these changes

@domenic domenic domenic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zcorpan @sideshowbarker @domenic