Skip to content

Fix errors in the tokenizer and tree construction tests. #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jul 5, 2021
Merged

Fix errors in the tokenizer and tree construction tests. #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
5a7149f
-- in a comment isn't an error
stevecheckoway Oct 1, 2018
c70ef7d
<!-----> is not an error
stevecheckoway Oct 1, 2018
4c2b23a
Add DOCTYPE errors (and remove one)
stevecheckoway Oct 3, 2018
4022182
Fix errors in doctypes
stevecheckoway Oct 2, 2018
607e334
Fix entity errors
stevecheckoway Oct 2, 2018
745869f
`<!doctype html><script><!` has only one error
stevecheckoway Oct 1, 2018
e295593
Include the new error in `#errors`
stevecheckoway Oct 3, 2018
c9e881e
Add missing foster-parenting errors; remove duplicate errors
stevecheckoway Oct 2, 2018
25b393d
The space is not foster parented
stevecheckoway Oct 1, 2018
20620b5
End tag causes two parse errors
stevecheckoway Oct 2, 2018
5ef4bd4
Add missing errors
stevecheckoway Oct 1, 2018
45d2577
Add missing errors
stevecheckoway Oct 2, 2018
dd97d25
More missing errors
stevecheckoway Oct 2, 2018
cc5b122
missing DOCTYPE and two foster parented elements
stevecheckoway Oct 1, 2018
e599f25
ruby closed with span still open
stevecheckoway Oct 1, 2018
5e88d5c
Add new errors to errors
stevecheckoway Oct 2, 2018
be61df3
Remove duplicated error messages
stevecheckoway Oct 2, 2018
05319d0
Remove duplicate errors
stevecheckoway Oct 2, 2018
b6520ef
Remove duplicate errors
stevecheckoway Oct 2, 2018
fa35532
Fix template errors
stevecheckoway Oct 2, 2018
65e3699
Fix EOF error line/columns, add to #errors
stevecheckoway Jun 26, 2021
26f2b8a
Add missing errors
stevecheckoway Jun 26, 2021
535e74b
Remove duplicated error
stevecheckoway Jun 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 0 additions & 24 deletions tree-construction/blocks.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
<!doctype html><p>foo<address>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “address”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -32,7 +31,6 @@
<!doctype html><p>foo<article>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “article”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -62,7 +60,6 @@
<!doctype html><p>foo<aside>bar<p>baz
#errors
(1,37): expected-closing-tag-but-got-eof
28: Unclosed element “aside”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -92,7 +89,6 @@
<!doctype html><p>foo<blockquote>bar<p>baz
#errors
(1,42): expected-closing-tag-but-got-eof
33: Unclosed element “blockquote”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -122,7 +118,6 @@
<!doctype html><p>foo<center>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “center”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -152,7 +147,6 @@
<!doctype html><p>foo<details>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “details”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -182,7 +176,6 @@
<!doctype html><p>foo<dialog>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “dialog”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -212,7 +205,6 @@
<!doctype html><p>foo<dir>bar<p>baz
#errors
(1,35): expected-closing-tag-but-got-eof
26: Unclosed element “dir”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -242,7 +234,6 @@
<!doctype html><p>foo<div>bar<p>baz
#errors
(1,35): expected-closing-tag-but-got-eof
26: Unclosed element “div”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -272,7 +263,6 @@
<!doctype html><p>foo<dl>bar<p>baz
#errors
(1,34): expected-closing-tag-but-got-eof
25: Unclosed element “dl”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -302,7 +292,6 @@
<!doctype html><p>foo<fieldset>bar<p>baz
#errors
(1,40): expected-closing-tag-but-got-eof
31: Unclosed element “fieldset”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -332,7 +321,6 @@
<!doctype html><p>foo<figcaption>bar<p>baz
#errors
(1,42): expected-closing-tag-but-got-eof
33: Unclosed element “figcaption”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -362,7 +350,6 @@
<!doctype html><p>foo<figure>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “figure”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -392,7 +379,6 @@
<!doctype html><p>foo<footer>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “footer”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -422,7 +408,6 @@
<!doctype html><p>foo<header>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “header”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -452,7 +437,6 @@
<!doctype html><p>foo<hgroup>bar<p>baz
#errors
(1,38): expected-closing-tag-but-got-eof
29: Unclosed element “hgroup”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -482,7 +466,6 @@
<!doctype html><p>foo<listing>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “listing”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -512,7 +495,6 @@
<!doctype html><p>foo<menu>bar<p>baz
#errors
(1,36): expected-closing-tag-but-got-eof
27: Unclosed element “menu”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -542,7 +524,6 @@
<!doctype html><p>foo<nav>bar<p>baz
#errors
(1,35): expected-closing-tag-but-got-eof
26: Unclosed element “nav”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -572,7 +553,6 @@
<!doctype html><p>foo<ol>bar<p>baz
#errors
(1,34): expected-closing-tag-but-got-eof
25: Unclosed element “ol”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -602,7 +582,6 @@
<!doctype html><p>foo<pre>bar<p>baz
#errors
(1,35): expected-closing-tag-but-got-eof
26: Unclosed element “pre”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -632,7 +611,6 @@
<!doctype html><p>foo<section>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “section”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -662,7 +640,6 @@
<!doctype html><p>foo<summary>bar<p>baz
#errors
(1,39): expected-closing-tag-but-got-eof
30: Unclosed element “summary”.
#document
| <!DOCTYPE html>
| <html>
Expand Down Expand Up @@ -692,7 +669,6 @@
<!doctype html><p>foo<ul>bar<p>baz
#errors
(1,34): expected-closing-tag-but-got-eof
25: Unclosed element “ul”.
#document
| <!DOCTYPE html>
| <html>
Expand Down
15 changes: 4 additions & 11 deletions tree-construction/comments01.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ FOO<!-- BAR --!>BAZ
FOO<!-- BAR --! >BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1:21) eof-in-comment
#new-errors
(1:20) eof-in-comment
(1:21) eof-in-comment
#document
| <html>
| <head>
Expand All @@ -43,8 +44,9 @@ FOO<!-- BAR --!
>BAZ
#errors
(1,3): expected-doctype-but-got-chars
(2:5) eof-in-comment
#new-errors
(1:20) eof-in-comment
(2:5) eof-in-comment
#document
| <html>
| <head>
Expand All @@ -57,7 +59,6 @@ FOO<!-- BAR --!
FOO<!-- BAR -- >BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1,15): unexpected-char-in-comment
(1,21): eof-in-comment
#new-errors
(1:22) eof-in-comment
Expand All @@ -72,8 +73,6 @@ FOO<!-- BAR -- >BAZ
FOO<!-- BAR -- <QUX> -- MUX -->BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1,15): unexpected-char-in-comment
(1,24): unexpected-char-in-comment
#document
| <html>
| <head>
Expand All @@ -86,8 +85,6 @@ FOO<!-- BAR -- <QUX> -- MUX -->BAZ
FOO<!-- BAR -- <QUX> -- MUX --!>BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1,15): unexpected-char-in-comment
(1,24): unexpected-char-in-comment
(1,31): unexpected-bang-after-double-dash-in-comment
#new-errors
(1:32) incorrectly-closed-comment
Expand All @@ -103,9 +100,6 @@ FOO<!-- BAR -- <QUX> -- MUX --!>BAZ
FOO<!-- BAR -- <QUX> -- MUX -- >BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1,15): unexpected-char-in-comment
(1,24): unexpected-char-in-comment
(1,31): unexpected-char-in-comment
(1,35): eof-in-comment
#new-errors
(1:36) eof-in-comment
Expand Down Expand Up @@ -202,7 +196,6 @@ FOO<!-->BAZ
FOO<!----->BAZ
#errors
(1,3): expected-doctype-but-got-chars
(1,10): unexpected-dash-after-double-dash-in-comment
#document
| <html>
| <head>
Expand Down
6 changes: 5 additions & 1 deletion tree-construction/doctype01.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
#data
<!DOCTYPE>Hello
#errors
(1,9): need-space-after-doctype
(1,10): expected-doctype-name-but-got-right-bracket
(1,10): unknown-doctype
#new-errors
Expand Down Expand Up @@ -337,6 +336,7 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"
"http://www.w3.org/TR/html4/strict.dtd">Hello
#errors
(2,43): unknown-doctype
#document
| <!DOCTYPE html "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
| <html>
Expand Down Expand Up @@ -421,6 +421,7 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN""http://www.w3.org/TR/html4/strict.dtd">
#errors
(1,50): unexpected-char-in-doctype
(1,89): unknown-doctype
#new-errors
(1:50) missing-whitespace-between-doctype-public-and-system-identifiers
#document
Expand All @@ -433,6 +434,7 @@
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN"'http://www.w3.org/TR/html4/strict.dtd'>
#errors
(1,50): unexpected-char-in-doctype
(1,89): unknown-doctype
#new-errors
(1:50) missing-whitespace-between-doctype-public-and-system-identifiers
#document
Expand All @@ -446,6 +448,7 @@
#errors
(1,21): unexpected-char-in-doctype
(1,49): unexpected-char-in-doctype
(1,88): unknown-doctype
#new-errors
(1:22) missing-whitespace-after-doctype-public-keyword
(1:49) missing-whitespace-between-doctype-public-and-system-identifiers
Expand All @@ -460,6 +463,7 @@
#errors
(1,21): unexpected-char-in-doctype
(1,49): unexpected-char-in-doctype
(1,88): unknown-doctype
#new-errors
(1:22) missing-whitespace-after-doctype-public-keyword
(1:49) missing-whitespace-between-doctype-public-and-system-identifiers
Expand Down
4 changes: 2 additions & 2 deletions tree-construction/entities02.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,6 @@
#data
<div bar="ZZ&gt=YY"></div>
#errors
(1,15): named-entity-without-semicolon
(1,20): expected-doctype-but-got-start-tag
#document
| <html>
Expand Down Expand Up @@ -204,7 +203,6 @@
#data
<div bar="ZZ&pound=23"></div>
#errors
(1,18): named-entity-without-semicolon
(1,23): expected-doctype-but-got-start-tag
#document
| <html>
Expand Down Expand Up @@ -299,6 +297,8 @@
#data
<div>ZZ&AElig=</div>
#errors
(1,5): expected-doctype-but-got-start-tag
(1:14) missing-semicolon-after-character-reference
#new-errors
(1:14) missing-semicolon-after-character-reference
#document
Expand Down
Loading