Fix Pytest4.x compatibility error #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to pytest docs: ``` marks in pytest.mark.parametrize Removed in version 4.0. Applying marks to values of a pytest.mark.parametrize call is now deprecated. ... This was considered hard to read and understand, and also its implementation presented problems to the code preventing further internal improvements in the marks architecture. To update the code, use pytest.param ``` Signed-off-by: Stanislav Levin <[email protected]>
stanislavlevin
force-pushed
the
fix_pytest4.x_compat
branch
from
1a66508 to
7be0c84
Compare
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 50 50
Lines 6952 6952
Branches 1328 1328
=======================================
Hits 6312 6312
Misses 481 481
Partials 159 159
Continue to review full report at Codecov.
|
hugovk
approved these changes
Nov 8, 2019
|
What's the status of this? Would be great to have a release that's compatible with |
This comment has been minimized.
This comment has been minimized.
|
Oh, wait, #429 is a superset of this. |
gsnedders
approved these changes
Feb 26, 2020
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to pytest docs: