Travis CI: Add Python 3.7 and pypy3 #417
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.4 is End of Life: https://devguide.python.org/devcycle/#end-of-life-branches [Travis are now recommending removing the __sudo__ tag](https://blog.travis-ci.com/2018-11-19-required-linux-infrastructure-migration). "_If you currently specify __sudo: false__ in your __.travis.yml__, we recommend removing that configuration_"
Codecov Report
@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 90.79% 90.79%
=======================================
Files 50 50
Lines 6952 6952
Branches 1328 1328
=======================================
Hits 6312 6312
Misses 481 481
Partials 159 159Continue to review full report at Codecov.
|
pytries/datrie#52 although ___closed___ is not yet released to https://pypi.org/project/datrie
|
FWIW: given we're a vendored dependency of pip, we've typically avoided dropping support for any version of Python still supported by pip, which implies we should still support Py3.4. |
cclauss
changed the title
gsnedders
approved these changes
Apr 18, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python 3.4 is End of Life: https://devguide.python.org/devcycle/#end-of-life-branches
Travis are now recommending removing the sudo tag.
"If you currently specify sudo: false in your .travis.yml, we recommend removing that configuration"
Conditionally install datrie only if on CPython < 3.7 as a workaround to pytries/datrie#52 which although closed is not yet released to https://pypi.org/project/datrie as discussed in pytries/datrie#68. It would also be possible to add
pip3 install git+https://github.com/pytries/datrie.giton CPython >= 3.7.