Fix Travis CI builds on Python 3.4 #352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid passing -U to pip install commands. It causes the six package to upgrade, which fails on the Travis 3.4 image. I cannot reproduce this locally, so I'm left to conclude that the Travis Python 3.4 image is corrupt in some way. The installed six package is perfectly fine for testing, so use it without upgrading. All builds now pass. Install six package first to avoid upgrading it then downgrading it in some test configurations.
willkg
approved these changes
Oct 31, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid passing
-Utopip installcommands. It causes the six package to upgrade, which fails on the Travis 3.4 image. I cannot reproduce this locally, so I'm left to conclude that the Travis Python 3.4 image is corrupt in some way. The installed six package is perfectly fine for testing, so use it without upgrading. All builds now pass.Install six package first to avoid upgrading it then downgrading it in some test configurations.