You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The actual warning is about importing ABCs using from collections instead of collections.abc . OrderedDict and deque can still be imported from collections. from collections import ... is going away only for ABCs. The linked PR blocking CPython is about ABCs and a quick scan of the listed files tells me this is fixed in html5lib.
Activity
serhiy-storchaka commentedon Dec 20, 2018
This is a blocker for CPython: python/cpython#10596.
tirkarthi commentedon Dec 20, 2018
Seems to be a duplicate of #402 ?
labrys commentedon Dec 22, 2018
@tirkarthi Not a duplicate as the issue still exists after #402 was closed.
from collections import ...
is still used in the following locations:html5lib._tokenizer
html5lib.html5parser
html5lib.filters.alphabeticalattributes
html5lib.tests.test_alphabeticalattributes
html5lib.treewalkers.etree
tirkarthi commentedon Dec 22, 2018
The actual warning is about importing ABCs using
from collections
instead of collections.abc . OrderedDict and deque can still be imported from collections.from collections import ...
is going away only for ABCs. The linked PR blocking CPython is about ABCs and a quick scan of the listed files tells me this is fixed in html5lib.labrys commentedon Dec 22, 2018
@tirkarthi you are correct... closing this