Update Hibernate ORM to 6.6.16 / Junit to 5.12.2 #517
Conversation
Bumps the test group with 1 update: [org.junit:junit-bom](https://github.com/junit-team/junit5). Updates `org.junit:junit-bom` from 5.11.4 to 5.12.2 - [Release notes](https://github.com/junit-team/junit5/releases) - [Commits](junit-team/junit5@r5.11.4...r5.12.2) --- updated-dependencies: - dependency-name: org.junit:junit-bom dependency-type: direct:production update-type: version-update:semver-minor dependency-group: test ... Signed-off-by: dependabot[bot] <[email protected]>
|
🥲 there was more to the junit upgrade than just the config 😄 so while that fix helps if no bytecode enhanced test are available ... it doesn't when there are such test (hibernate/hibernate-orm@e8e4678#diff-b995d5674fe0fc0a3e4d47a22144bff7e7139f077714a1cda05f6629b741cb3fL160-L166) |
Thanks for taking care of this. Is the problem specific to test case templates? Why would the Hibernate ORM test suite pass and not these? |
|
oh it work fine in ORM as versions are always aligned there (for ORM builds), and when there's a misalignment it is the TCK tests that run on the older version of Junit... but since those tests (from TCK) do not have any bytecode enhanced tests (none are using this extension/engine) the code never reaches the part where it creates the test descriptors ... |
|
so no... the problem is not test case template specific 😖 ideally we'd want a new extension point in junit apis to get this working nicely without relying on any internal classes |
|
I thought Christian had suggested/merged precisely a change that would allow not relying on internal classes...? |
|
mm not really, it was essentially just using another internal class that hasn't changed yet, and since tck never reached the other code block, the error we see here didn't manifest itself. btw a fun fact, JUnit 5.13 is out and it has more breaking changes in these internal apis, the patch is simple, but then as before we won't have backwards compatibility 🥲 |
No description provided.