Create QueryProducer interface for Stage and Mutiny

[DavideD]

A first draft of the shared session contract. I've basically collected the methods we already have in both sessions.

See Mutiny.SharedSessionContract (or Stage.SharedSessionContract).
Personally, I like knowing which methods are not specific to a session.

[gavinking]

SharedSessionContract is not a good name, so before anything else, an acceptable name needs to be found.

[gavinking]

Also, please don't move fetch() up. It has different semantics between the two kinds of session.

[gavinking]

Also not sure it's a good idea to move batchFetchSize onto StatelessSession. That was left off deliberately.

[DavideD]

OK, I'm going to revert back the fetch and getBatchFetchSize().

[DavideD]

OK, I'm going to revert back the fetch and getBatchFetchSize().

Done

[DavideD]

By the way, why do we have .persist(Object) and .persist(Object...). Isn't the second one enough?

[gavinking]

By the way, why do we have .persist(Object) and .persist(Object...). Isn't the second one enough?

Just avoids an array instantiation in the overwhelmingly more common case that you're only passing one entity. That's unlikely to be a huge overhead, but the overload doesn't cause any problems that I'm aware of.

[DavideD]

Should I close this PR or are we going to merge it if the shared contract has a different name?

[gavinking]

I think if it were called QueryProducer, and had only query-related operations, then I would like it a whole lot more.

[DavideD]

I've renamed the interface QueryReproducer, and I've included the following method:

<R> SelectionQuery<R> createSelectionQuery(String queryString, Class<R> resultType);
<R> Query<R> createQuery(TypedQueryReference<R> typedQueryReference);
MutationQuery createMutationQuery(String queryString);
MutationQuery createMutationQuery(CriteriaUpdate<?> updateQuery);
MutationQuery createMutationQuery(CriteriaDelete<?> deleteQuery);
MutationQuery createMutationQuery(JpaCriteriaInsert<?> insert);
<R> Query<R> createQuery(String queryString);
<R> SelectionQuery<R> createQuery(String queryString, Class<R> resultType);
<R> SelectionQuery<R> createQuery(CriteriaQuery<R> criteriaQuery);
<R> MutationQuery createQuery(CriteriaUpdate<R> criteriaUpdate);
<R> MutationQuery createQuery(CriteriaDelete<R> criteriaDelete);
<R> Query<R> createNamedQuery(String queryName);
<R> SelectionQuery<R> createNamedQuery(String queryName, Class<R> resultType);
<R> Query<R> createNativeQuery(String queryString);
<R> Query<R> createNativeQuery(String queryString, AffectedEntities affectedEntities);
<R> SelectionQuery<R> createNativeQuery(String queryString, Class<R> resultType);
<R> SelectionQuery<R> createNativeQuery(String queryString, Class<R> resultType, AffectedEntities affectedEntities);
<R> SelectionQuery<R> createNativeQuery(String queryString, ResultSetMapping<R> resultSetMapping);
<R> SelectionQuery<R> createNativeQuery(String queryString, ResultSetMapping<R> resultSetMapping, AffectedEntities affectedEntities);
CriteriaBuilder getCriteriaBuilder();

<T> EntityGraph<T> getEntityGraph(Class<T> rootType, String graphName);
<T> EntityGraph<T> createEntityGraph(Class<T> rootType);
<T> EntityGraph<T> createEntityGraph(Class<T> rootType, String graphName);

Object getIdentifier(Object entity);
<T> ResultSetMapping<T> getResultSetMapping(Class<T> resultType, String mappingName);
<T> Uni<T> unproxy(T association);

[gavinking]

Object getIdentifier(Object entity);

Let's not pull this one up, it's nothing to do with queries, and in ORM it's not pulled up because it has different semantics between Session and StatelessSession.

<T> Uni<T> unproxy(T association);

Why pull up unproxy() but not fetch()?

[FroMage]

LGTM :)

[DavideD]

Why pull up unproxy() but not fetch()?

I removed them from QueryProducer and left them where they are now

[DavideD]

@gavinking I think we can merge it now, but can you give it another look and let me know if there's more to change, please?

[DavideD]

If anything, this should be at least a good starting point

[gavinking]

Fine, I mean the diff is utterly unreadable, so it's pretty hard to give much feedback.

[DavideD]

Merged, thanks!