Upgrade Hibernate ORM to 6.5 #1870
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| resultSetAccess.release(); | ||
| } | ||
|
|
||
| public void finishRowProcessing(RowProcessingState rowProcessingState, boolean wasAdded) { |
Check notice
Code scanning / CodeQL
Useless parameter
...ain/java/org/hibernate/reactive/generator/values/internal/ReactiveGeneratedValuesHelper.java
Fixed
Show fixed
Hide fixed
...e-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveAbstractReturningDelegate.java
Fixed
Show fixed
Hide fixed
...e-core/src/main/java/org/hibernate/reactive/id/insert/ReactiveAbstractReturningDelegate.java
Fixed
Show fixed
Hide fixed
...ctive-core/src/main/java/org/hibernate/reactive/query/sqm/internal/ReactiveQuerySqmImpl.java
Fixed
Show fixed
Hide fixed
Comment on lines
+180
to
+192
| mutationGroup.forEachOperation( (position, operation) -> { | ||
| final EntityTableMapping tableDetails = (EntityTableMapping) operation.getTableDetails(); | ||
| if ( tableInclusionChecker.include( tableDetails ) ) { | ||
| final int[] attributeIndexes = tableDetails.getAttributeIndexes(); | ||
| for ( final int attributeIndex : attributeIndexes ) { | ||
| if ( propertyInclusions[attributeIndex] ) { | ||
| final AttributeMapping mapping = entityPersister().getAttributeMappings().get( attributeIndex ); | ||
| decomposeAttribute( values[attributeIndex], session, jdbcValueBindings, mapping ); | ||
| } | ||
| } | ||
| } | ||
| } ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
Comment on lines
+193
to
+202
| mutationGroup.forEachOperation( (position, jdbcOperation) -> { | ||
| if ( id == null ) { | ||
| assert entityPersister().getIdentityInsertDelegate() != null; | ||
| } | ||
| else { | ||
| final EntityTableMapping tableDetails = (EntityTableMapping) jdbcOperation.getTableDetails(); | ||
| breakDownJdbcValue( id, session, jdbcValueBindings, tableDetails ); | ||
| } | ||
| } ); |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
|
|
||
| mutationGroup.forEachOperation( (position, jdbcOperation) -> { | ||
| if ( id == null ) { | ||
| assert entityPersister().getIdentityInsertDelegate() != null; |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation
DavideD
force-pushed
the
wip/orm-6.5
branch
2 times, most recently
from
f4ef46d to
3fa01d7
Compare
|
|
||
| default CompletionStage<GeneratedValues> performReactiveNonBatchedOperations( | ||
| Object modelReference, | ||
| ValuesAnalysis valuesAnalysis, |
Check notice
Code scanning / CodeQL
Useless parameter
| @@ -141,7 +141,8 @@ | |||
| } | |||
| final JdbcValueBindings jdbcValueBindings = mutationExecutor.getJdbcValueBindings(); | |||
| bindPartitionColumnValueBindings( loadedState, session, jdbcValueBindings ); | |||
| applyId( id, rowId, mutationExecutor, getStaticDeleteGroup(), session ); | |||
| applyId( id, rowId, mutationExecutor, getStaticMutationOperationGroup(), session ); | |||
| String[] identifierColumnNames = entityPersister().getIdentifierColumnNames(); | |||
Check notice
Code scanning / CodeQL
Unread local variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1857
Requires next Hibernate ORM release and it currently uses the snapshots.
One test related to the
@Generatedannotation is disabled for MySQL and MariaDB.