Skip to content

Remove unused code that causes error on in Quarkus at start up #1839

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 19, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
package org.hibernate.reactive.persister.entity.impl;


import org.hibernate.dialect.OracleDialect;
import org.hibernate.engine.spi.SessionFactoryImplementor;
import org.hibernate.persister.entity.AbstractEntityPersister;
import org.hibernate.persister.entity.mutation.MergeCoordinator;
Expand All @@ -22,7 +21,6 @@
import org.hibernate.sql.model.ast.TableMutation;
import org.hibernate.sql.model.internal.MutationOperationGroupFactory;
import org.hibernate.sql.model.internal.OptionalTableUpdate;
import org.hibernate.sql.model.jdbc.DeleteOrUpsertOperation;
import org.hibernate.sql.model.jdbc.OptionalTableUpdateOperation;

public class ReactiveMergeCoordinatorStandardScopeFactory extends MergeCoordinator
Expand All @@ -46,6 +44,7 @@ public ReactiveScopedUpdateCoordinator makeScopedCoordinator() {
);
}

// We override the whole method but we just need to plug in our custom createOperation(...) method
@Override
protected MutationOperationGroup createOperationGroup(ValuesAnalysis valuesAnalysis, MutationGroup mutationGroup) {
final int numberOfTableMutations = mutationGroup.getNumberOfTableMutations();
Expand Down Expand Up @@ -101,15 +100,6 @@ protected MutationOperation createOperation(ValuesAnalysis valuesAnalysis, Table
factory()
);
}
if ( operation instanceof DeleteOrUpsertOperation
&& factory().getJdbcServices().getDialect() instanceof OracleDialect ) {
OracleDialect dialect = ( (OracleDialect) factory().getJdbcServices().getDialect() );
return dialect.createOptionalTableUpdateOperation(
( (OptionalTableUpdate) operation ).getMutationTarget(),
(OptionalTableUpdate) operation,
factory()
);
}
return operation;
}
}