Skip to content

We are ignoring the return value of ReactiveUpdateRowsCoordinatorOneToMany#deleteRows #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Jan 22, 2025 · 0 comments · Fixed by #2085 or quarkusio/quarkus#46189
Closed

We are ignoring the return value of ReactiveUpdateRowsCoordinatorOneToMany#deleteRows #2079

DavideD opened this issue Jan 22, 2025 · 0 comments · Fixed by #2085 or quarkusio/quarkus#46189
Assignees
@DavideD
Labels
bug Something isn't working
Milestone
3.0.0.Beta2

Comments

@DavideD
Copy link
Member

DavideD commented Jan 22, 2025

deleteRows returns a CompletionStage, but we are ignoring it in doReactiveUpdate.
@DavideD DavideD added the bug Something isn't working label Jan 22, 2025
@DavideD DavideD added this to the 3.0.0.Beta2 milestone Jan 22, 2025
@DavideD DavideD changed the title We are ignoring the value of ReactiveUpdateRowsCoordinatorOneToMany#deleteRows We are ignoring the return value of ReactiveUpdateRowsCoordinatorOneToMany#deleteRows Jan 23, 2025
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 24, 2025
@DavideD
[hibernate#2079] Don't ignore return value of ReactiveUpdateRowsCoord…
81bd9af 
…inatorOneToMany#deleteRows
@DavideD DavideD mentioned this issue Jan 24, 2025
Merged
@DavideD DavideD self-assigned this Jan 24, 2025
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 24, 2025
@DavideD
[hibernate#2079] Don't ignore return value of ReactiveUpdateRowsCoord…
4ce518b 
…inatorOneToMany#deleteRows
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 24, 2025
@DavideD
[hibernate#2079] Don't ignore return value of ReactiveUpdateRowsCoord…
47ae4cb 
…inatorOneToMany#deleteRows
@DavideD DavideD mentioned this issue Jan 24, 2025
Merged
DavideD added a commit that referenced this issue Jan 24, 2025
@DavideD
[#2079] Don't ignore return value of ReactiveUpdateRowsCoordinatorOne…
347f1a7 
…ToMany#deleteRows
DavideD added a commit that referenced this issue Jan 24, 2025
@DavideD
[#2079] Don't ignore return value of ReactiveUpdateRowsCoordinatorOne…
002dda3 
…ToMany#deleteRows
@DavideD DavideD mentioned this issue Feb 4, 2025
Open
@DavideD DavideD mentioned this issue Feb 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
bug Something isn't working
Projects
None yet
Milestone
3.0.0.Beta2
1 participant
@DavideD