Skip to content

Replace toString with JsonObject#encode #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Sep 27, 2024 · 1 comment
Closed

Replace toString with JsonObject#encode #2000

DavideD opened this issue Sep 27, 2024 · 1 comment
Assignees
@DavideD
Labels
enhancement New feature or request

Comments

@DavideD
Copy link
Member

DavideD commented Sep 27, 2024

Currently, we are using toString or encodePrettily
@DavideD DavideD self-assigned this Sep 27, 2024
@DavideD DavideD added the enhancement New feature or request label Sep 27, 2024
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 27, 2024
@DavideD
[hibernate#2000] When converting a JsonObject to string, we should us…
cc723b3 
…e JsonObject#encode
@DavideD DavideD mentioned this issue Sep 27, 2024
Closed
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Sep 27, 2024
@DavideD
[hibernate#2000] When converting a JsonObject to string, we should us…
200e443 
…e JsonObject#encode
@DavideD DavideD changed the title When converting a JsonObject to string, we should use JsonObject#encode Replace toString with JsonObject Sep 27, 2024
@DavideD DavideD changed the title Replace toString with JsonObject Replace toString with JsonObject#encode Sep 27, 2024
@DavideD
Copy link
Member Author

DavideD commented Sep 27, 2024

Closing this one as not planned. Change this in StringToJsonConverter will just create a different string when people upgrade. I doesn't seem a good idea.

@DavideD DavideD closed this as not planned Won't fix, can't repro, duplicate, stale Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use encode instead of toString DavideD/hibernate-reactive
1 participant
@DavideD