Skip to content

ReactiveIdentifierGenerator must extends Generator #1826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Jan 4, 2024 · 0 comments · Fixed by #2028
Closed

ReactiveIdentifierGenerator must extends Generator #1826

DavideD opened this issue Jan 4, 2024 · 0 comments · Fixed by #2028
Assignees
@DavideD
Milestone
3.0.0.Beta1

Comments

@DavideD
Copy link
Member

DavideD commented Jan 4, 2024

The strategy attribute in @GenericGenerator is deprecated.

The recommended approach is to use the type attribute. But, ReactiveIdentifier doesn't implement the interface making it harder for the user to create a custom generator.

Related existing test: CustomGeneratorTest

Original issue in Quarkus: quarkusio/quarkus#37983
@DavideD DavideD modified the milestones: 3.0.0.Alpha1, next Oct 4, 2024
@DavideD DavideD self-assigned this Nov 8, 2024
@DavideD DavideD modified the milestones: next, 3.0.0.Alpha1 Nov 8, 2024
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Nov 14, 2024
@DavideD
[hibernate#1826] ReactiveIdentifierGenerator
a8c5994
@DavideD DavideD added problem A limitation or source of discomfort and removed problem A limitation or source of discomfort labels Dec 6, 2024
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 12, 2024
@DavideD
[hibernate#1895] Upgrade Hibernate ORM to 7.0.0.Beta3
091dc72 
Notes:

* Fix hibernate#1826: ReactiveIdentifierGenerator must extends Generator
* The Hibernate Gradle plugin has not been released yet, so we keep it to 7.0.0.Beta2
* XML sql data type is not supported: eclipse-vertx/vertx-sql-client#1475
* Stop using `org.hibernate.dialect.DialectDelegateWrapper` (not
  required anymore)
* Remove `ReactiveOracleSqlAstTranslator` (not required anymore)
* Only process parameters for native queries. See hibernate#2012
* Remove `ReactiveIdentifierGeneratorFactory`: the service doesn't exist
  anymore in ORM
* Add `persist(String, Object)` to the session
* Remove test for `hibernate.create_empty_composites.enabled`: see [HHH-18222](https://hibernate.atlassian.net/browse/HHH-18222)
* Contains some clean ups
* There are still some issues with embeddable mapped as JSON and native queries: See hibernate#1999
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 13, 2024
@DavideD
[hibernate#1895] Upgrade Hibernate ORM to 7.0.0.Beta3
15c2f2d 
Notes:

* Fix hibernate#1826: ReactiveIdentifierGenerator must extends Generator
* The Hibernate Gradle plugin has not been released yet, so we keep it to 7.0.0.Beta2
* XML sql data type is not supported: eclipse-vertx/vertx-sql-client#1475
* Stop using `org.hibernate.dialect.DialectDelegateWrapper` (not
  required anymore)
* Remove `ReactiveOracleSqlAstTranslator` (not required anymore)
* Only process parameters for native queries. See hibernate#2012
* Remove `ReactiveIdentifierGeneratorFactory`: the service doesn't exist
  anymore in ORM
* Add `persist(String, Object)` to the session
* Remove test for `hibernate.create_empty_composites.enabled`: see [HHH-18222](https://hibernate.atlassian.net/browse/HHH-18222)
* Contains some clean ups
* There are still some issues with embeddable mapped as JSON and native queries: See hibernate#1999
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Dec 13, 2024
@DavideD
[hibernate#1895] Upgrade Hibernate ORM to 7.0.0.Beta3
1f51d8a 
Notes:

* Fix hibernate#1826: ReactiveIdentifierGenerator must extends Generator
* The Hibernate Gradle plugin has not been released yet, so we keep it to 7.0.0.Beta2
* XML sql data type is not supported: eclipse-vertx/vertx-sql-client#1475
* Stop using `org.hibernate.dialect.DialectDelegateWrapper` (not
  required anymore)
* Remove `ReactiveOracleSqlAstTranslator` (not required anymore)
* Only process parameters for native queries. See hibernate#2012
* Remove `ReactiveIdentifierGeneratorFactory`: the service doesn't exist
  anymore in ORM
* Add `persist(String, Object)` to the session
* Remove test for `hibernate.create_empty_composites.enabled`: see [HHH-18222](https://hibernate.atlassian.net/browse/HHH-18222)
* Contains some clean ups
* There are still some issues with embeddable mapped as JSON and native queries: See hibernate#1999
DavideD added a commit that referenced this issue Dec 13, 2024
@DavideD
[#1895] Upgrade Hibernate ORM to 7.0.0.Beta3
b72c5a6 
Notes:

* Fix #1826: ReactiveIdentifierGenerator must extends Generator
* The Hibernate Gradle plugin has not been released yet, so we keep it to 7.0.0.Beta2
* XML sql data type is not supported: eclipse-vertx/vertx-sql-client#1475
* Stop using `org.hibernate.dialect.DialectDelegateWrapper` (not
  required anymore)
* Remove `ReactiveOracleSqlAstTranslator` (not required anymore)
* Only process parameters for native queries. See #2012
* Remove `ReactiveIdentifierGeneratorFactory`: the service doesn't exist
  anymore in ORM
* Add `persist(String, Object)` to the session
* Remove test for `hibernate.create_empty_composites.enabled`: see [HHH-18222](https://hibernate.atlassian.net/browse/HHH-18222)
* Contains some clean ups
* There are still some issues with embeddable mapped as JSON and native queries: See #1999
@DavideD DavideD mentioned this issue Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DavideD DavideD

Labels
None yet
Projects
None yet
Milestone
3.0.0.Beta1
Development

Successfully merging a pull request may close this issue.

Upgrade Hibernate ORM to 7.0.0.Beta3 DavideD/hibernate-reactive
1 participant
@DavideD