Skip to content

add lock() method #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gavinking opened this issue May 19, 2020 · 3 comments · Fixed by #195
Closed

add lock() method #142

gavinking opened this issue May 19, 2020 · 3 comments · Fixed by #195
Labels
enhancement New feature or request
Milestone
FIRST CUT

Comments

@gavinking
Copy link
Member

Following on from #43, we should add the Session.lock() method.

This is not a high priority at all.
@gavinking gavinking added the enhancement New feature or request label May 19, 2020
@gavinking gavinking added this to the NEXT milestone May 19, 2020
@gavinking gavinking mentioned this issue May 19, 2020
Closed
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue May 26, 2020
@gavinking
basic infrastructure for lock()
55d0e3d 
but not for locking strategies / other lock modes

supported:

- PESSIMISTIC_LOCK_MODE_WRITE
- PESSIMISTIC_LOCK_MODE_READ

see hibernate#142
@gavinking gavinking mentioned this issue May 26, 2020
Merged
@gavinking
Copy link
Member Author

So it looks like we'll have something in the first release. But Hibernate has a plethora of lock modes and I'm not sure I want to implement all of them right now.

@gavinking gavinking modified the milestones: NEXT, FIRST CUT May 26, 2020
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue May 27, 2020
@gavinking
support for lock() operation
dfc256f 
supported lock modes:

- PESSIMISTIC_LOCK_MODE_WRITE
- PESSIMISTIC_LOCK_MODE_FORCE_INCREMENT
- PESSIMISTIC_LOCK_MODE_READ

not supported:

- optimistic lock modes

see hibernate#142
gavinking added a commit to gavinking/hibernate-reactive that referenced this issue May 27, 2020
@gavinking
support for lock() operation
146fbf9 
supported lock modes:

- PESSIMISTIC_LOCK_MODE_WRITE
- PESSIMISTIC_LOCK_MODE_FORCE_INCREMENT
- PESSIMISTIC_LOCK_MODE_READ

not supported:

- optimistic lock modes

see hibernate#142
@gavinking gavinking linked a pull request May 27, 2020 that will close this issue
lock() method #195
Merged
gavinking added a commit that referenced this issue May 27, 2020
@gavinking
support for lock() operation
e19fbc7 
supported lock modes:

- PESSIMISTIC_LOCK_MODE_WRITE
- PESSIMISTIC_LOCK_MODE_FORCE_INCREMENT
- PESSIMISTIC_LOCK_MODE_READ

not supported:

- optimistic lock modes

see #142
@gavinking
Copy link
Member Author

Done!

@gavinking
Copy link
Member Author

(Followup work in #201.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
FIRST CUT
Development

Successfully merging a pull request may close this issue.

lock() method gavinking/hibernate-reactive
1 participant
@gavinking