Persist of entity mapped with a non nullable association causes UnsupportedOperationException

[DavideD]

Mapping example:

@JoinColumn(name = "device_id", nullable = false)
@ManyToOne(fetch = FetchType.LAZY, targetEntity = Device.class, optional = false)
private Device device;

Setting either nullable = false or optional = false will cause the following exception during a persist:

Caused by: java.lang.UnsupportedOperationException: reactive persistence context
	at org.hibernate.reactive.engine.impl.ReactivePersistenceContextAdapter.getDatabaseSnapshot(ReactivePersistenceContextAdapter.java:76)
	at org.hibernate.engine.internal.ForeignKeys.isTransient(ForeignKeys.java:306)
	at org.hibernate.engine.internal.ForeignKeys$Nullifier.isNullifiable(ForeignKeys.java:230)
	at org.hibernate.engine.internal.ForeignKeys$Nullifier.access$000(ForeignKeys.java:36)
	at org.hibernate.engine.internal.ForeignKeys.collectNonNullableTransientEntities(ForeignKeys.java:414)
	at org.hibernate.engine.internal.ForeignKeys.findNonNullableTransientEntities(ForeignKeys.java:385)
	at org.hibernate.action.internal.AbstractEntityInsertAction.findNonNullableTransientEntities(AbstractEntityInsertAction.java:91)
	at org.hibernate.reactive.engine.ReactiveActionQueue.addInsertAction(ReactiveActionQueue.java:346)
	at org.hibernate.reactive.engine.ReactiveActionQueue.addAction(ReactiveActionQueue.java:331)

[blafond]

@DavideD I pushed some tests to a branch that replicates the error as well as starts adding the missing implementations to wrap the logic to discover any non-nullable dependent entities.

Got down to ReactiveEntityRegularInsertAction which uses ForeignKeys to find/collect the relevant entities.

I'm stuck right now because most of the implementation on the ORM side is in an internal package. There's already a hibernate ForeignKeys class that is based on the ORM version, but it's incomplete. I started adding the missing logic to it, however, the critical utility class NonNullableTransientDependencies is on the interface and it's internal as well.

Not sure how to proceed to get past the hidden/private/internal ORM code.

I'll ping you first thing Monday ... with more questions :)

[DavideD]

It's a bit tricky, but at first glance you need to add a method to our ForeignKeys that mimics findNonNullableTransientEntities from the one in Hibernate ORM. The difference is that it will return a CompletionStage<NonNullableTransientDependencies>.

The implementation of this method needs to call the isNullifiable in Reactive (and not the one in ORM).

[blafond]

My commits start down that road... here.

My roadblock is with ORM's NonNullableTransientDependencies and ForeignKeys internal classes.. they are final and access to NonNullableTransientDependencies.add(String propertyName, Object transientEntity) isn't available. So implementing a reactive ForeignKeys.collectNonNullableTransientEntities(...) to "add" non-nullable entities isn't possible.

[DavideD]

Ok, but you don’t have to extend the classes, you need to copy and adapt the code for the method

…

On 28 Jan 2022, at 20:06, Barry LaFond ***@***.***> wrote:  My commits start down that road... here. My roadblock is with ORM's NonNullableTransientDependencies and ForeignKeys internal classes.. they are final and access to NonNullableTransientDependencies.add(String propertyName, Object transientEntity) isn't available. So implementing a reactive ForeignKeys.collectNonNullableTransientEntities(...) to "add" non-nullable entities isn't possible. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[DavideD]

I see now.
You can prepare a PR for Hibernate ORM that change the visibility of the add method and see if they are fine with it.
But the method is package-private, so you don't have to wait for the next ORM realease if you move the class using the method to a package with the same name (org.hibernate.engine.internal).

[DavideD]

Waiting fo rORM 5.6.7.Final