Skip to content

DefaultVertxInstance should not create a new Vertx instance if one exists already #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DavideD opened this issue Oct 15, 2021 · 0 comments · Fixed by #1003
Closed

DefaultVertxInstance should not create a new Vertx instance if one exists already #1001

DavideD opened this issue Oct 15, 2021 · 0 comments · Fixed by #1003
Milestone
1.0.0.Final

Comments

@DavideD
Copy link
Member

DavideD commented Oct 15, 2021

See this discussion.
@DavideD DavideD mentioned this issue Oct 15, 2021
Closed
@codingxu97 codingxu97 mentioned this issue Oct 15, 2021
Closed
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Oct 16, 2021
@codingxu97 @DavideD
[hibernate#1001] Don't create a new Vert.x instance is one exists
cc4cddc 
DefaultVertxInstance used to create a new Vert.x instance
every time, even if one was already present.

This commit make it easier to use Hibernate Reactive when
a Vert.x instance already exists. In particular, when used
with Vert.x verticles.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 16, 2021
@DavideD
[hibernate#1001] Remove setup of custom VertxInstance for tests
918bdcc 
It's not required anymore because now we get the
Vert.x instance from the current context.
DavideD pushed a commit to DavideD/hibernate-reactive that referenced this issue Oct 16, 2021
@codingxu97 @DavideD
[hibernate#1001] Don't create a new Vert.x instance if one exists
21ddc12 
DefaultVertxInstance used to create a new Vert.x instance
every time, even if one was already present.

This commit make it easier to use Hibernate Reactive when
a Vert.x instance already exists. In particular, when used
with Vert.x verticles.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Oct 16, 2021
@DavideD
[hibernate#1001] Remove setup of custom VertxInstance for tests
ede99c0 
It's not required anymore because now we get the
Vert.x instance from the current context.
@DavideD DavideD mentioned this issue Oct 16, 2021
Merged
DavideD pushed a commit that referenced this issue Oct 18, 2021
@codingxu97 @DavideD
[#1001] Don't create a new Vert.x instance if one exists
8b799cb 
DefaultVertxInstance used to create a new Vert.x instance
every time, even if one was already present.

This commit make it easier to use Hibernate Reactive when
a Vert.x instance already exists. In particular, when used
with Vert.x verticles.
DavideD added a commit that referenced this issue Oct 18, 2021
@DavideD
[#1001] Remove setup of custom VertxInstance for tests
75454d5 
It's not required anymore because now we get the
Vert.x instance from the current context.
@DavideD DavideD added this to the 1.0.0.Final milestone Oct 18, 2021
@DavideD DavideD mentioned this issue Oct 18, 2021
Merged
@markusdlugi markusdlugi mentioned this issue Jan 10, 2022
Closed
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 11, 2022
@DavideD
Revert "[hibernate#1001] Don't create a new Vert.x instance if one ex…
f43a43a 
…ists"

This reverts commit 21ddc12.
DavideD added a commit to DavideD/hibernate-reactive that referenced this issue Jan 11, 2022
@DavideD
Revert "[hibernate#1001] Remove setup of custom VertxInstance for tests"
7a081f0 
This reverts commit ede99c0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0.Final
1 participant
@DavideD