Changes for Hibernate Reactive #9264
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavideD
force-pushed
the
HHH-18854-HR-3
branch
from
0bcd408 to
dd782ca
Compare
|
Comments added |
Thanks man |
DavideD
force-pushed
the
HHH-18854-HR-3
branch
from
dd782ca to
f0b8dca
Compare
|
Rebased to the latest changes and added a minor refactoring: f0b8dca |
DavideD
force-pushed
the
HHH-18854-HR-3
branch
from
f0b8dca to
25790c2
Compare
|
Added another small refactoring: 25790c2 |
gavinking
reviewed
Nov 21, 2024
hibernate-core/src/main/java/org/hibernate/persister/entity/AbstractEntityPersister.java
Outdated
Show resolved
Hide resolved
DavideD
force-pushed
the
HHH-18854-HR-3
branch
2 times, most recently
from
511a321 to
dae0877
Compare
|
@sebersole Is it OK to merge this before the next release? (After I've applied the change Gavin asked) |
|
@gavinking Is this better? 7be8d0b |
Um, well, it's less code, so ... I guess?? |
gavinking
requested changes
Nov 26, 2024
hibernate-core/src/main/java/org/hibernate/metamodel/spi/RuntimeModelCreationContext.java
Outdated
Show resolved
Hide resolved
Hibernate Reactive extends this class and needs to access/overrides some of the methods.
Hibernate Reactive needs to replace or extends the original id generators. This changes make it possible to pass a function to the EntityMetamodel that allows Hibernate Reactive to replace the original id generators
With this change I can remove a lot of duplicate code in Hibernate Reactive.
refactoring Allow me to remove some duplicated code in Hibernate Reactive
Change the parameter to JdbcType so that Hibernate Reactive can call it when in need to create the array.
Because I didn't add a comment, some of the methods Hibernate Reactive uses to plug in its classess, have been removed as a refactoring.
And move the `createEntityMetamodel` method in `RuntimeModelCreationContext`
DavideD
force-pushed
the
HHH-18854-HR-3
branch
from
7be8d0b to
51f64ab
Compare
Looks fine to me, I'll get it applied today. |
|
We need to figure out this failure first though |
gavinking
approved these changes
Nov 26, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix HHH-18854 (I think)
These changes make it possible for me to use Hibernate Reactive with ORM 7 and Postgres.
I still need to fix some issues with the other databases, but I don't think I will have more changes to include for now.
Basically, I needed some way to intercept the creation of the id generator.