HHH-15497 Count query when counting polymorphic subclasses by type fails when run twice #5275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
beikov
reviewed
Sep 13, 2022
| @@ -156,4 +156,8 @@ public JpaSelection<T> alias(String name) { | |||
| public JavaType<T> getJavaTypeDescriptor() { | |||
| return getNodeType() == null ? null : getNodeType().getExpressibleJavaType(); | |||
| } | |||
|
|
|||
| public void forceInferableType(SqmExpressible<?> type){ | |||
There was a problem hiding this comment.
I think we should move the logic from org.hibernate.query.internal.QueryParameterBindingImpl#setType to AbstractSqmParameter#applyInferableType and call that method instead. Changing the type of the parameter binding is a no-go AFAIU from our last discussion, so we shouldn't do it and deprecate the setType method.
|
superseded by #5277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-15497,
When a query is executed a second time the binding type adjustment is not executes, so aligning the SqmParameter expressible type with the binding type while converting SQM->AST will ensure that even for the following query execution the binding type will be correct one