Skip to content

HHH-4384 Allow join column override if @JoinColumn is absent on @OneToOne(mappedBy = ""). #3057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

HHH-4384 Allow join column override if @JoinColumn is absent on @OneToOne(mappedBy = ""). #3057

wants to merge 1 commit into from

Conversation

ettavolt
Copy link
Contributor

@ettavolt ettavolt commented Oct 4, 2019 •
edited
Loading

https://hibernate.atlassian.net/browse/HHH-4384

Tests: this case and disallow if mappedBy > "".

If isEmptyAnnotationValue is left, it breaks many other cases, incl. ManyToOne.

Base automatically changed from master to main March 19, 2021 16:00
@ettavolt
HHH-4384 Allow join column override if @joincolumn is absent on @Onet…
c441e1b 
…oOne(mappedBy = "").

Tests: this case and disallow if mappedBy > "".
@ettavolt ettavolt mentioned this pull request Apr 26, 2022
Closed
@dreab8
Copy link
Member

dreab8 commented May 4, 2022 •
edited
Loading

Hi @ettavolt ,

thanks a lot for your PR, I'm closing it in favour of #5012 where I have changed the test, I have also created #5013 for master.

@dreab8 dreab8 closed this May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ettavolt @dreab8