-
-
Notifications
You must be signed in to change notification settings - Fork 3
Add standard Linux paths to libpq.def #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add `/usr/include` and `/usr/lib64` to compiler and linker options respectively. This should cover majority of x64 linux systems.
Can you please add a reason why do you need it? These paths are for development only, afaik. |
@hfhbd Without this change the project doesn't build under Linux (Fedora 38, but I assume more Linux systems will also suffer from this). |
Head branch was pushed to by a user without write access
Not sure why the linuxArm64 build suddenly started failing (I have trouble cross-compiling linux_x64 to linux_arm64 on my system both before as well as after my change...) but perhaps moving the settings into platform-specific |
I think the failures are caused to the fact the local |
Head branch was pushed to by a user without write access
Another shot with a more narrow |
+1 and here the reasons why.
These paths are also for both development of dependent projects and runtime as well because You might build a static native library instead, but your binary wouldn't be published with generated JARs, so other developers cannot use it as a dependency from Maven. |
@matobet I added some paths, do you need more? |
@hfhbd it seems on Fedora I still need to add
(without the |
Okay, can you just update the PR? Thanks. |
The tricky part here is to come up with such paths that make the project build both on fedora && on ubuntu (CI)... |
Add
/usr/include
and/usr/lib64
to compiler and linker options respectively.This should cover majority of x64 linux systems.