Use cc_binary

Author: kon72

BUILD

@@ -25,13 +25,10 @@ filegroup(
 # Implementation:
 # If you are looking into the implementation, start with the overview in ImplementationReadme.md.
 
-exports_files(["refresh.template.py", "check_python_version.template.py", "print_args.py"])  # For implicit use by the refresh_compile_commands macro, not direct use.
+exports_files(["refresh.template.py", "check_python_version.template.py"])  # For implicit use by the refresh_compile_commands macro, not direct use.
 
-filegroup(
+cc_binary(
     name = "print_args",
-    srcs = select({
-        "@bazel_tools//src/conditions:host_windows": [":print_args.bat"],
-        "//conditions:default": [":print_args.sh"],
-    }),
+    srcs = ["print_args.cc"],
     visibility = ["//visibility:public"],
 )

print_args.bat

@@ -0,0 +1,13 @@
+// Prints the arguments passed to the script
+
+#include <iostream>
+
+int main(int argc, char *argv[]) {
+  std::cout << "===HEDRON_COMPILE_COMMANDS_BEGIN_ARGS===\n";
+  for (int i = 1; i < argc; ++i) {
+    std::cout << argv[i] << "\n";
+  }
+  std::cout << "===HEDRON_COMPILE_COMMANDS_END_ARGS===\n";
+  // We purposely return a non-zero exit code to have the emcc process exit after running this fake clang wrapper.
+  return 1;
+}

print_args.cc

@@ -780,7 +780,6 @@ def get_workspace_root(path_from_execroot: pathlib.PurePath):
         'EM_CONFIG_PATH': str(get_workspace_root(emcc_driver) / 'emscripten_toolchain' / 'emscripten_config'),
         'EMCC_SKIP_SANITY_CHECK': '1',
         'EM_COMPILER_WRAPPER': str(pathlib.PurePath({print_args_executable})),
-        'HEDRON_COMPILE_COMMANDS_PRINT_ARGS_PY': str(pathlib.PurePath({print_args_py})),
         'PATH': os.environ['PATH'],
     }
 

print_args.py

@@ -117,7 +117,6 @@ def _expand_template_impl(ctx):
             "{exclude_headers}": repr(ctx.attr.exclude_headers),
             "{exclude_external_sources}": repr(ctx.attr.exclude_external_sources),
             "{print_args_executable}": repr(ctx.executable._print_args_executable.path),
-            "{print_args_py}": repr(ctx.file._print_args_py.path),
         },
     )
     return DefaultInfo(files = depset([script]))
@@ -128,8 +127,7 @@ _expand_template = rule(
         "exclude_external_sources": attr.bool(default = False),
         "exclude_headers": attr.string(values = ["all", "external", ""]),  # "" needed only for compatibility with Bazel < 3.6.0
         "_script_template": attr.label(allow_single_file = True, default = "refresh.template.py"),
-        "_print_args_executable": attr.label(executable = True, allow_single_file = True, cfg = "target", default = "print_args"),
-        "_print_args_py": attr.label(allow_single_file = True, default = "print_args.py"),
+        "_print_args_executable": attr.label(executable = True, cfg = "target", default = "//:print_args"),
         # For Windows INCLUDE. If this were eliminated, for example by the resolution of https://github.com/clangd/clangd/issues/123, we'd be able to just use a macro and skylib's expand_template rule: https://github.com/bazelbuild/bazel-skylib/pull/330
         # Once https://github.com/bazelbuild/bazel/pull/17108 is widely released, we should be able to eliminate this and get INCLUDE directly. Perhaps for 7.0? Should be released in the sucessor to 6.0
         "_cc_toolchain": attr.label(default = "@bazel_tools//tools/cpp:current_cc_toolchain"),